Replace logging with logger for consistency

[wiltonsr]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Walkthrough

The Prometheus metrics service module replaces three logging calls using the standard logging module with a module-level logger instance. Changes affect OpenShift token loading messages without altering control flow or error handling logic.

Changes

Cohort / File(s)	Summary
Logging refactoring robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py	Replaced logging.info() and logging.warning() calls with module-level logger instance for token load attempts, successful token loads, and missing token warnings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title "Replace logging with logger for consistency" accurately and specifically describes the main change in the changeset. The modification involves refactoring logging calls in a Prometheus metrics service file to use a module-level logger instance instead of the global logging module, and the title clearly captures this intent. The title is concise, specific enough for a teammate to understand the primary change, and directly related to the actual implementation modifications.
Description Check	✅ Passed	No pull request description was provided by the author beyond the title. While the description field is empty and therefore does not explicitly relate to the changeset, it is also not "completely off-topic" or misleading in any way. Given the lenient nature of this check, an absent description that does not make any competing or contradictory claims about the changes meets the basic threshold of not being unrelated to the changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df17896 and ff57a6f.

📒 Files selected for processing (1)

• robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py (1)

robusta_krr/core/integrations/openshift/token.py (1)

• load_token (9-17)

🔇 Additional comments (1)

robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py (1)

79-86: LGTM! Excellent consistency improvement.

These changes replace the root logging module calls with the module-level logger instance, making the logging consistent throughout the file. All other logging calls in this file already use logger, so this brings these three lines into alignment with established patterns. Using a named logger instead of the root logger is a Python logging best practice.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}