add CharSequence.length feature extractor (fluent/infix) #2106

joonseolee · 2025-10-28T00:48:44Z

Summary

Add Expect<CharSequence>.length feature extractor for fluent and infix APIs.

Related Issue

Expect<CharSequence>.length #2102

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

joonseolee · 2025-10-28T00:49:08Z

@robstoll

Can you check this PR?

robstoll

@joonseolee looks already very good. Just an addition and we are good to merge

...ommonMain/kotlin/ch/tutteli/atrium/specs/integration/AbstractCharSequenceExpectationsTest.kt

codecov · 2025-10-28T06:17:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (7426369) to head (ab01751).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2106      +/-   ##
============================================
- Coverage     91.31%   91.30%   -0.01%     
  Complexity      125      125              
============================================
  Files           467      468       +1     
  Lines          4776     4783       +7     
  Branches        242      242              
============================================
+ Hits           4361     4367       +6     
  Misses          366      366              
- Partials         49       50       +1

Flag	Coverage Δ
current	`90.92% <100.00%> (-0.01%)`	⬇️
current_windows	`90.02% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

...ent/src/commonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/CharSequenceExpectationsTest.kt

...-fluent/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/charSequenceExpectations.kt

...mmonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/CharSequenceExpectationSamples.kt

robstoll · 2025-10-29T06:08:36Z

apis/infix/atrium-api-infix/api/main/atrium-api-infix.api

+	public static final fun getLength (Lch/tutteli/atrium/creating/Expect;)Lch/tutteli/atrium/creating/Expect;
+	public static final fun length (Lch/tutteli/atrium/creating/Expect;Lkotlin/jvm/functions/Function1;)Lch/tutteli/atrium/creating/Expect;


please re-run ./gradlew apiDump & KOTLIN_VERSION=1.9 ./gradlew apiDump once you have moved the code as outlined above

...pi-infix/src/commonMain/kotlin/ch/tutteli/atrium/api/infix/en_GB/charSequenceExpectations.kt

robstoll · 2025-10-29T06:12:59Z

...nfix/src/commonTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/CharSequenceExpectationsTest.kt

+    ("length" to Companion::lengthFeature).withFeatureSuffix(),
+    "length" to Companion::length
 ) {
    companion object {
        private fun toBeEmpty(expect: Expect<CharSequence>) = expect toBe empty
        private fun notToBeEmpty(expect: Expect<CharSequence>) = expect notToBe empty
        private fun notToBeBlank(expect: Expect<CharSequence>) = expect notToBe blank
+        private fun lengthFeature(expect: Expect<CharSequence>): Expect<Int> =
+            expect.length
+
+        private fun length(
+            expect: Expect<CharSequence>,
+            assertionCreator: Expect<Int>.() -> Unit
+        ): Expect<Int> = expect.length.apply(assertionCreator)


same same revert to what you had previously

robstoll · 2025-10-29T06:13:10Z

...nfix/src/commonTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/CharSequenceExpectationsTest.kt

        a1 = a1 toMatch Regex(".+Robert")
        a1 = a1 notToMatch Regex("a")
+
+        a1 = a1 length { it toEqual 23 }


val l1 =...

...ommonTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/CharSequenceExpectationSamples.kt

...ommonMain/kotlin/ch/tutteli/atrium/specs/integration/AbstractCharSequenceExpectationsTest.kt

robstoll · 2025-10-29T06:37:01Z

...ommonMain/kotlin/ch/tutteli/atrium/specs/integration/AbstractCharSequenceExpectationsTest.kt

        toMatchSpec.forSubjectLessTest(Regex("")),
        notToMatchSpec.forSubjectLessTest(Regex(""))
    )



also something I overlooked 🙈
Can you please add

@TestFactory fun expectationCreatorTest() = expectationCreatorTestFactory(

@robstoll - Do you mean you want a block for the expectationCreatorTest with the same logic as as the subjectLessTest?

Each expectation function which expects an expectationCreator-lambda (i.e. length { ... } should have an

@TestFactory fun expectationCreatorTest() = expectationCreatorTestFactory( )

test. The test checks that an empty lambda causes an error.
I see that we should rename it to expectationCreatorEmptyTest but that's something we can do in a subsequent PR for all cases. Take a look at other usages of expectationCreatorTestFactory. Hope that helps

...ommonMain/kotlin/ch/tutteli/atrium/specs/integration/AbstractCharSequenceExpectationsTest.kt

robstoll · 2025-11-14T08:36:01Z

@joonseolee do you intend to finish it or shall we take over?

robstoll · 2025-11-17T21:47:03Z

@TomerPacific would you like to take over? Something else than a migration for a change.

TomerPacific · 2025-11-19T17:17:43Z

@robstoll -

But I can't make any promises

TomerPacific · 2025-11-22T16:53:48Z

@robstoll - I am having compile issues in the ExpectationsTest classes (infix & fluent), but I believe these are due to the method definitions in the abstract class.
I have posted above how the Abstract class's constructor looks like.
This is how it looks like for one of the test classes:

class CharSequenceExpectationsTest : AbstractCharSequenceExpectationsTest(
    fun0(Expect<CharSequence>::toBeEmpty),
    fun0(Expect<CharSequence>::notToBeEmpty),
    fun0(Expect<CharSequence>::notToBeBlank),
    fun1(Expect<CharSequence>::toStartWith),
    fun1(Expect<CharSequence>::notToStartWith),
    fun1(Expect<CharSequence>::toEndWith),
    fun1(Expect<CharSequence>::notToEndWith),
    fun1(Expect<CharSequence>::toMatch),
    fun1(Expect<CharSequence>::notToMatch),
    property(Expect<CharSequence>::length),
    fun1(Expect<CharSequence>::length)
) {

Let me know what needs to be changed.

robstoll · 2025-11-22T20:54:46Z

@TomerPacific nothing needs to be changed there, that's all good. The problem is that you create a class CharSequenceFeatureExtractors in fluent/infix. Remove it, we want top-level functions (see other .kt files in the API)

...nt/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/CharSequenceFeatureExtractors.kt

TomerPacific · 2025-11-23T19:58:59Z

@TomerPacific nothing needs to be changed there, that's all good. The problem is that you create a class CharSequenceFeatureExtractors in fluent/infix. Remove it, we want top-level functions (see other .kt files in the API)

Regarding this, I did not create the class in infix and it seems to be in the right syntax.
Thing is, should the constructor of the CharSequenceExpectationsTest in infix look like this?

class CharSequenceExpectationsTest : AbstractCharSequenceExpectationsTest(
    "toBe ${empty::class.simpleName}" to Companion::toBeEmpty,
    "notToBe ${empty::class.simpleName}" to Companion::notToBeEmpty,
    "notToBe ${blank::class.simpleName}" to Companion::notToBeBlank,
    fun1(Expect<CharSequence>::toStartWith),
    fun1(Expect<CharSequence>::notToStartWith),
    fun1(Expect<CharSequence>::toEndWith),
    fun1(Expect<CharSequence>::notToEndWith),
    fun1(Expect<CharSequence>::toMatch),
    fun1(Expect<CharSequence>::notToMatch),
    property(Expect<CharSequence>::length),
    fun1(Expect<CharSequence>::length)
) {

I have looked at the previous commit and there is no change to the lines with the Companion reference, but I don't think those should remain.

robstoll · 2025-11-23T20:30:18Z

@TomerPacific regarding the infix-api, the following should work:

    property(Expect<CharSequence>::length),
    fun1(Expect<CharSequence>::length)

No need for the Companion, but you need to fix the constructor of AbstractCharSequenceExpectationsTest. Currently you still have:

    private val lengthFeatureSpec: Feature0<CharSequence, Int>,
    private val lengthSpec: Feature1<CharSequence, Expect<Int>.() -> Unit, Int>,

but as you pointed out here #2106 (comment), lengthSpec needs to be Fun1

TomerPacific · 2025-11-28T15:28:43Z

@robstoll - Been a bit busy this week. Hopefully I'll have time this weekend.

joonseolee requested a review from robstoll as a code owner October 28, 2025 00:48

robstoll requested changes Oct 28, 2025

View reviewed changes

...ommonMain/kotlin/ch/tutteli/atrium/specs/integration/AbstractCharSequenceExpectationsTest.kt Outdated Show resolved Hide resolved

robstoll linked an issue Oct 28, 2025 that may be closed by this pull request

Expect<CharSequence>.length #2102

Open

19 tasks

add CharSequence.length feature extractor (fluent/infix)

ab01751

joonseolee force-pushed the feature/add-charsequence-length branch from 5bc99b8 to ab01751 Compare October 28, 2025 23:29

robstoll requested changes Oct 29, 2025

View reviewed changes

robstoll reviewed Oct 29, 2025

View reviewed changes

...ommonMain/kotlin/ch/tutteli/atrium/specs/integration/AbstractCharSequenceExpectationsTest.kt Show resolved Hide resolved

TomerPacific added 5 commits November 20, 2025 23:12

issue-2102 PR fixes

cbb3598

issue-2102 migrating code to new file

9106e15

issue-2102 renaming class

6a1b6e8

issue-2102 extracting code to new class

0634386

issue-2102 extracting code to new class

744d68c

robstoll reviewed Nov 22, 2025

View reviewed changes

...nt/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/CharSequenceFeatureExtractors.kt Outdated Show resolved Hide resolved

TomerPacific added 2 commits November 23, 2025 21:43

issue-2102 renaming class and removing class declaration

5979cbf

issue-2102 correcting fluent test class

3674228

		public static final fun getLength (Lch/tutteli/atrium/creating/Expect;)Lch/tutteli/atrium/creating/Expect;
		public static final fun length (Lch/tutteli/atrium/creating/Expect;Lkotlin/jvm/functions/Function1;)Lch/tutteli/atrium/creating/Expect;

Uh oh!

add CharSequence.length feature extractor (fluent/infix) #2106

Are you sure you want to change the base?

add CharSequence.length feature extractor (fluent/infix) #2106

Uh oh!

Conversation

joonseolee commented Oct 28, 2025

Summary

Related Issue

Uh oh!

joonseolee commented Oct 28, 2025

Uh oh!

robstoll left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robstoll Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

robstoll Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

robstoll Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robstoll Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

TomerPacific Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

robstoll Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

robstoll commented Nov 14, 2025

Uh oh!

robstoll commented Nov 17, 2025

Uh oh!

TomerPacific commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomerPacific commented Nov 22, 2025

Uh oh!

robstoll commented Nov 22, 2025

Uh oh!

Uh oh!

TomerPacific commented Nov 23, 2025

Uh oh!

robstoll commented Nov 23, 2025

Uh oh!

TomerPacific commented Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 28, 2025 •

edited

Loading

TomerPacific commented Nov 19, 2025 •

edited

Loading