Skip to content

Add get all subsystems #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add get all subsystems #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc6e6d6
Add function
OhmV-IR Feb 28, 2025
07ad2df
Add test
OhmV-IR Feb 28, 2025
c567484
test reliability
OhmV-IR Feb 28, 2025
aeb61c8
Fix return value type
OhmV-IR Feb 28, 2025
0682624
Add newline at end of test file
OhmV-IR Feb 28, 2025
1c6f1f4
Remove unneeded table in commandscheduler.py
OhmV-IR Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions commands2/commandscheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,12 @@
for subsystem in subsystems:
self._subsystems.pop(subsystem, None)

def getAllSubsystems(self) -> tuple[Subsystem, ...]:
"""
Gets all registered subsystems as an immutable tuple.
"""
return tuple(self._subsystems.keys())

def unregisterAllSubsystems(self):
"""
Un-registers all registered Subsystems with the scheduler. All currently registered subsystems
Expand Down Expand Up @@ -653,5 +659,5 @@
self.cancel(cancelCmd)

builder.addIntegerArrayProperty(
"Cancel", lambda: [], lambda to_cancel: cancel_commands(to_cancel)

Check failure on line 662 in commands2/commandscheduler.py

View workflow job for this annotation

GitHub Actions / check-mypy 

Argument 1 to "cancel_commands" has incompatible type "list[SupportsInt]"; expected "list[int]"
)
18 changes: 18 additions & 0 deletions tests/test_command_schedule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,21 @@ def test_notScheduledCancel(scheduler: commands2.CommandScheduler):
command = commands2.Command()

scheduler.cancel(command)

def test_getAllSubystems(scheduler: commands2.CommandScheduler):
sub1 = commands2.Subsystem()
sub1.setName("test123")
sub2 = commands2.Subsystem()
sub2.setName("hey")
start_spying_on(sub1)
start_spying_on(sub2)
scheduler.registerSubsystem(sub1)
scheduler.registerSubsystem(sub2)
sublist = scheduler.getAllSubsystems()
con1 = sublist[0].getName() == "test123"
con2 = sublist[0].getName() == "hey"
assert con1 or con2
if(con1):
assert sublist[1].getName() == "hey"
else:
assert sublist[1].getName() == "test123"
Loading