Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trigger.onChange #69

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Add Trigger.onChange #69

merged 1 commit into from
Jun 27, 2024

Conversation

spacey-sooty
Copy link
Contributor

Resolves #65

TheTripleV
TheTripleV requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@TheTripleV TheTripleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

commands2/button/trigger.py Outdated Show resolved Hide resolved
@TheTripleV TheTripleV merged commit 3eac469 into robotpy:main Jun 27, 2024
19 checks passed
@TheTripleV
Copy link
Member

Weird that java has no test for it

@spacey-sooty spacey-sooty deleted the triggeronchange branch July 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheTripleV TheTripleV TheTripleV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Trigger.onChange
2 participants
@spacey-sooty @TheTripleV