Skip to content

Conversation

@iamawesomecat
Copy link
Contributor

No description provided.

@iamawesomecat
Copy link
Contributor Author

do not recall if this was tested, will comment later when i find out

@iamawesomecat iamawesomecat marked this pull request as ready for review August 16, 2025 22:28
@Jetblackdragon
Copy link
Contributor

@TrisDooley L1 scoring fix theoretically, can you test it?

@Jetblackdragon
Copy link
Contributor

I had the wrong pr earlier

Copy link
Contributor

@TrisDooley TrisDooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L1 is functional: https://youtube.com/shorts/dULDGUOwhrU?si=8FCpUWVhwwEVJE_r

but coral mode is moving the funnel a whole bunch and causing feeding issues (this has been an issue for a while): https://youtube.com/shorts/y6AVyoost7U?si=eJjIRzwfvFisGtO9

@iamawesomecat
Copy link
Contributor Author

L1 is functional: https://youtube.com/shorts/dULDGUOwhrU?si=8FCpUWVhwwEVJE_r

but coral mode is moving the funnel a whole bunch and causing feeding issues (this has been an issue for a while): https://youtube.com/shorts/y6AVyoost7U?si=eJjIRzwfvFisGtO9

The funnel behaves like that due to the way its written, it was originally intended to not need precise inputs, so due to being strained on time, I wrote it with bang bang control. Additionally, it has a relatively high range for each preset, so it never really is 100% accurate. This can be fixed, but I believe that it would require me to manually tune it with the bot.

@TrisDooley
Copy link
Contributor

PXL_20250825_233934986 MP
Yeah we should fix it it's pretty annoying. If you can prep code we can tune it before practice tomorrow

@iamawesomecat
Copy link
Contributor Author

PXL_20250825_233934986 MP Yeah we should fix it it's pretty annoying. If you can prep code we can tune it before practice tomorrow

Shouldnt need any code prep, in theory its just some variable changes

@Jetblackdragon Jetblackdragon added bug Something isn't working ClimbPivot Subsystem Issue involving the climb pivot Subsystem SuperStructure Subsystem Issue involving the SuperStructure Subsystem labels Aug 26, 2025
@Jetblackdragon
Copy link
Contributor

I am merging this and creating a new issue for the funnel stuff so we have l1s working again

@Jetblackdragon Jetblackdragon dismissed TrisDooley’s stale review August 28, 2025 03:36

Moving requested changes to a new issue.

@RobototesProgrammers RobototesProgrammers merged commit 4301b10 into main Aug 28, 2025
2 checks passed
@RobototesProgrammers RobototesProgrammers deleted the post-worlds-fixes branch August 28, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ClimbPivot Subsystem Issue involving the climb pivot Subsystem SuperStructure Subsystem Issue involving the SuperStructure Subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants