-
Notifications
You must be signed in to change notification settings - Fork 9
Some small code fixes made post-season #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
do not recall if this was tested, will comment later when i find out |
|
@TrisDooley L1 scoring fix theoretically, can you test it? |
|
I had the wrong pr earlier |
TrisDooley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L1 is functional: https://youtube.com/shorts/dULDGUOwhrU?si=8FCpUWVhwwEVJE_r
but coral mode is moving the funnel a whole bunch and causing feeding issues (this has been an issue for a while): https://youtube.com/shorts/y6AVyoost7U?si=eJjIRzwfvFisGtO9
…o post-worlds-fixes
The funnel behaves like that due to the way its written, it was originally intended to not need precise inputs, so due to being strained on time, I wrote it with bang bang control. Additionally, it has a relatively high range for each preset, so it never really is 100% accurate. This can be fixed, but I believe that it would require me to manually tune it with the bot. |
|
I am merging this and creating a new issue for the funnel stuff so we have l1s working again |
Moving requested changes to a new issue.


No description provided.