Retain products requests (necessary for tvOS) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergiou87 I'm implementing this functionality now; do you know any reason why your PR appears to be unmerged, and if you edits work well. Much appreciated! |
|
Nope, no idea why it's unmerged 🤷♂️ 😞 This code works well, yeah, it's what our app uses everyday 😄 |
|
Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the same problem as #163: on tvOS, instances of
SKProductsRequestare not retained by the framework, so the app needs to retain them. Otherwise, we won't get the delegated called.This PR is different from #163 because this one allows a user of RMStore to perform multiple requests in parallel, while in #163 subsequent requests would deallocate the previous ones, being the last one the only one that would call the delegate methods.