-
Notifications
You must be signed in to change notification settings - Fork 116
Add ROS 2 Launch System + Documentation #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…anual launch_ros.sh + Added docs on launch system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file have any benefit over directly running
ros2 launch rosbridge_server rosbridge_websocket_launch.xml
?
Having a python file makes sense when launching multiple nodes at once (like with turtlesim), of course.
What is the issue that this file is trying to address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that:
- it incorporates within the launch file information about the ip/port of the rosbridge (defaul 127.0.0.1:9090).
- it manages more gently startup/shutdown.
- it creates a baseline for running rosbridge with other nodes, some sort of template launch.py
- it is easier to find and users don't have to remember the specific command:
ros2 launch rosbridge_server rosbridge_websocket_launch.xml
Can be removed if not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intended audience for this instruction file?
Specifically the line "The ROS-MCP Server uses proper ROS2 launch files for process management." is a bit confusing since the ROS-MCP server does not explicitly need to use any launch files at all.
They are useful tools in the examples and tutorials, and having good, modern launch files for these is valuable. But do we need a document telling users of the MCP server about why we chose certain launch systems for the examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a guide that provides template launch files for developers to integrate their robots with the ROS-MCP Server. These templates demonstrate how to combine your robot's existing launch files with rosbridge for MCP communication.
Future Vision: As rosbridge becomes a standard ROS node, the ROS-MCP Server itself will be launchable through ROS2 launch files, making integration even more seamless.
Ready for Review ✅ |
70b2b79
to
6f5a7df
Compare
Closes #136 |
Closes #136
Completed Tasks:
Key Improvements:
Usage Examples:
The new launch system provides better reliability, easier maintenance, and proper integration with ROS2 tooling compared to the manual shell script approach.
Ready for Review ✅