Skip to content

Conversation

lucas-m-ribeiro
Copy link

  • Hello @nottyo, I would like to contribute to this pull request by implementing a new keyword for the redis library. This implementation will be responsible for safely disconnecting the database. This implementation resolves the reported issue No disconnect keyword #32 (comment)
    I hope that this contribution adds positively to the project and that everyone can benefit. I would like feedback on the implementation. I am available to answer any possible questions.

Copy link

@leonpros leonpros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change method name and keyword

Copy link

@leonpros leonpros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants