.NET 9 compilation

.editorconfig

@@ -51,6 +51,7 @@ dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
 dotnet_style_prefer_auto_properties = true:silent
 dotnet_style_prefer_conditional_expression_over_assignment = true:silent
 dotnet_style_prefer_conditional_expression_over_return = true:silent
+dotnet_style_namespace_match_folder = true:silent
 ###############################
 # Naming Conventions          #
 ###############################
@@ -92,6 +93,8 @@ csharp_style_deconstructed_variable_declaration = true:suggestion
 csharp_prefer_simple_default_expression = true:suggestion
 csharp_style_pattern_local_over_anonymous_function = true:suggestion
 csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_namespace_declarations = file_scoped
+csharp_style_prefer_primary_constructors= false:silent
 ###############################
 # C# Formatting Rules         #
 ###############################

codehelp/CodeHelpers.Test/LogGenerator/LogGeneratorTest.cs

@@ -1,7 +1,6 @@
 namespace CodeHelpers.Test.LogGenerator;
 
 using System.Text;
-using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Testing;
 using Microsoft.CodeAnalysis.Testing;
 using Microsoft.CodeAnalysis.Text;

codehelp/CodeHelpers.Test/LogGenerator/LogGeneratorTestVb.cs

@@ -1,7 +1,6 @@
 namespace CodeHelpers.Test.LogGenerator;
 
 using System.Text;
-using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.Testing;
 using Microsoft.CodeAnalysis.Text;
 using Microsoft.CodeAnalysis.VisualBasic.Testing;

codehelp/CodeHelpers/IndentedStringBuilder.cs

@@ -1,5 +1,4 @@
 using System.Text;
-using Microsoft.CodeAnalysis;
 
 namespace WPILib.CodeHelpers;
 

codehelp/CodeHelpers/LogGenerator/LogAttributeInfo.cs

@@ -2,7 +2,6 @@
 using System.Text;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp;
-using Microsoft.CodeAnalysis.PooledObjects;
 using Stereologue;
 
 namespace WPILib.CodeHelpers.LogGenerator;

codehelp/CodeHelpers/LogGenerator/LoggableType.cs

@@ -4,7 +4,6 @@
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.Text;
 using WPILib.CodeHelpers.LogGenerator.Analyzer;
-using static WPILib.CodeHelpers.IndentedStringBuilder;
 
 namespace WPILib.CodeHelpers.LogGenerator;
 

codehelp/CodeHelpers/LogGenerator/SourceGenerator/LogGeneratorVb.cs

@@ -1,5 +1,4 @@
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.VisualBasic.Syntax;
 
 namespace WPILib.CodeHelpers.LogGenerator.SourceGenerator;

codehelp/CodeHelpers/ParameterlessStructs/Analyzer/ParameterlessStructDiagnostics.cs

@@ -3,8 +3,6 @@ namespace WPILib.CodeHelpers.ParameterlessStructs.Analyzer;
 #pragma warning disable RS2008 // Enable analyzer release tracking
 
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.Diagnostics;
-using WPILib.CodeHelpers;
 
 public static class ParameterlessStructDiagnostics
 {

codehelp/CodeHelpers/SymbolExtensions.cs

@@ -1,5 +1,4 @@
 using Microsoft.CodeAnalysis;
-using Microsoft.CodeAnalysis.CSharp.Syntax;
 
 namespace WPILib.CodeHelpers;
 

codehelp/CodeHelpers/TypeDeclarationModel.cs

@@ -1,5 +1,4 @@
 using System.Collections.Immutable;
-using System.Text;
 using Microsoft.CodeAnalysis;
 
 namespace WPILib.CodeHelpers;

dev/desktopDev/Program.cs

@@ -1,15 +1,10 @@
 using System;
 using System.IO;
 using System.Linq;
-using System.Runtime.InteropServices;
 using System.Text.Json;
-using CsCore;
-using CsCore.Raw;
 using UnitsNet.NumberExtensions.NumberToAngle;
 using WPIHal.Natives.Simulation;
 using WPIMath.Geometry;
-using WPIUtil;
-using WPIUtil.Natives;
 using WPIUtil.Serialization.Struct;
 
 namespace DesktopDev;

src/hal/CANStreamMessage.cs

@@ -16,7 +16,11 @@ public struct CANStreamMessage
     [System.Runtime.CompilerServices.InlineArray(8)]
     public struct DataBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 }
 
@@ -42,6 +46,10 @@ public CANMessage(ReadOnlySpan<byte> buffer, ulong timestamp)
     [InlineArray(8)]
     public struct DataBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 }

src/hal/JoystickAxis.cs

@@ -11,13 +11,21 @@ public readonly struct JoystickAxes
     [System.Runtime.CompilerServices.InlineArray(NumJoystickAxes)]
     public struct AxesBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private float _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 
     [System.Runtime.CompilerServices.InlineArray(NumJoystickAxes)]
     public struct RawBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
     private readonly short m_count;
     private readonly AxesBuffer m_axes;

src/hal/JoystickDescriptor.cs

@@ -34,7 +34,9 @@ public struct NativeJoystickDescriptor
         [System.Runtime.CompilerServices.InlineArray(256)]
         public struct NameBuffer
         {
+#pragma warning disable IDE0044 // Add readonly modifier
             private byte _element0;
+#pragma warning restore IDE0044 // Add readonly modifier
 
             public readonly unsafe string FromNullTerminatedString()
             {
@@ -49,7 +51,11 @@ public readonly unsafe string FromNullTerminatedString()
         [System.Runtime.CompilerServices.InlineArray(12)]
         public struct AxesTypeBuffer
         {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
             private byte _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
 
             public readonly unsafe int[] FromRawBytes(int length)
             {

src/hal/JoystickPOVs.cs

@@ -11,7 +11,11 @@ public readonly struct JoystickPOVs
     [System.Runtime.CompilerServices.InlineArray(NumJoystickPOVs)]
     public struct PovsBuffer
     {
+#pragma warning disable IDE0044 // Add readonly modifier
+#pragma warning disable IDE0051 // Remove unused private members
         private short _element0;
+#pragma warning restore IDE0051 // Remove unused private members
+#pragma warning restore IDE0044 // Add readonly modifier
     }
 
     private readonly short m_count;

src/hal/Natives/Simulation/HalAccelerometerData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalAddressableLEDData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_ConstBufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 

src/hal/Natives/Simulation/HalAnalogGyroData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalAnalogInData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalAnalogOutData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalAnalogTriggerData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalCTREPCMData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalDIOData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalDigitalPWMData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalDutyCycleData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalEncoderData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalNotifierData.cs

@@ -1,7 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
-using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
 

src/hal/Natives/Simulation/HalPWMData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalPowerDistributionData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalREVPHData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalRelayData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/HalSPIAccelerometerData.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
 using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;

src/hal/Natives/Simulation/NotifyListener.cs

@@ -1,8 +1,3 @@
-using System.Runtime.CompilerServices;
-using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
-using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
-
 namespace WPIHal.Natives.Simulation;
 
 public static unsafe partial class HalNotifyListener

src/hal/Natives/Simulation/Reset.cs

@@ -1,7 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using unsafe HAL_BufferCallback = delegate* unmanaged[Cdecl]<byte*, void*, byte*, uint, void>;
-using unsafe HAL_NotifyCallback = delegate* unmanaged[Cdecl]<byte*, void*, WPIHal.HalValue*, void>;
 
 namespace WPIHal.Natives.Simulation;
 

src/newcommands/Command.cs

@@ -1,5 +1,3 @@
-using System;
-using System.Collections.Generic;
 using CommunityToolkit.Diagnostics;
 using WPIUtil.Sendable;
 

src/newcommands/ConditionalCommand.cs

@@ -6,7 +6,9 @@ public class ConditionalCommand : Command
 {
     private readonly Command m_onTrue;
     private readonly Command m_onFalse;
+#pragma warning disable IDE0052 // Remove unread private members
     private readonly Func<bool> m_condition;
+#pragma warning restore IDE0052 // Remove unread private members
 
     public ConditionalCommand(Command onTrue, Command onFalse, Func<bool> condition)
     {

src/newcommands/DeferredCommand.cs

@@ -6,8 +6,10 @@ public class DeferredCommand : Command
 {
     private readonly Command m_nullCommand = new PrintCommand("[DeferredCommand] Supplied command was null!");
 
+#pragma warning disable IDE0052 // Remove unread private members
     private readonly Func<Command> m_supplier;
     private Command m_command;
+#pragma warning restore IDE0052 // Remove unread private members
 
     public DeferredCommand(Func<Command> supplier, HashSet<ISubsystem> requirements)
     {

src/ntcore/ConnectionInfo.cs

@@ -1,8 +1,9 @@
 using System.Runtime.InteropServices;
 using System.Runtime.InteropServices.Marshalling;
+using NetworkTables.Natives;
 using WPIUtil.Marshal;
 
-namespace NetworkTables.Natives;
+namespace NetworkTables;
 
 [NativeMarshalling(typeof(ConnectionInfoMarshaller))]
 [StructLayout(LayoutKind.Auto)]

src/ntcore/NetworkTable.cs

@@ -1,6 +1,5 @@
 using System.Collections.Concurrent;
 using NetworkTables.Handles;
-using NetworkTables.Natives;
 
 namespace NetworkTables;
 

src/ntcore/TopicInfo.cs

@@ -1,9 +1,10 @@
 using System.Runtime.InteropServices;
 using System.Runtime.InteropServices.Marshalling;
 using NetworkTables.Handles;
+using NetworkTables.Natives;
 using WPIUtil.Marshal;
 
-namespace NetworkTables.Natives;
+namespace NetworkTables;
 
 [NativeMarshalling(typeof(TopicInfoMarshaller))]
 [StructLayout(LayoutKind.Auto)]

src/stereologue/Attributes.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace Stereologue;
 
 [AttributeUsage(AttributeTargets.Property | AttributeTargets.Method | AttributeTargets.Field, Inherited = false, AllowMultiple = false)]

src/stereologue/LogType.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace Stereologue;
 
 [Flags]

src/stereologue/Stereologuer.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
-using Google.Protobuf.WellKnownTypes;
 using NetworkTables;
 using WPIUtil.Logging;
 using WPIUtil.Serialization.Protobuf;
@@ -18,7 +17,9 @@ private Stereologuer() { }
 
     public static Stereologuer Logger { get; } = new();
 
+#pragma warning disable IDE0060 // Remove unused parameter
     public void Setup(string name, bool fileOnly, bool lazyLogging)
+#pragma warning restore IDE0060 // Remove unused parameter
     {
         rootPath = name;
         FileOnly = fileOnly;