Update the "Automated Migration" page #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the [Automated Migration](https://robolectric.org/automated-migration/) page. The changes are: - Adding Kotlin code sample. - Update the procedure to match recent versions of Error Prone.
MGaetan89
commented
Sep 22, 2024
| apply plugin: "net.ltgt.errorprone" | ||
|
|
||
| dependencies { | ||
| errorprone "com.google.errorprone:error_prone_core:2.3.2" | ||
| errorproneJavac "com.google.errorprone:javac:9+181-r4173-1" |
There was a problem hiding this comment.
From what I could see, this dependency is added automatically by the Gradle plugin, for specific Java versions:
https://github.com/tbroyer/gradle-errorprone-plugin/blob/e22bbca556aca14bc10e34324675877c67ad5f0e/src/main/kotlin/net/ltgt/gradle/errorprone/ErrorPronePlugin.kt#L103-L111
|
|
||
| ```bash | ||
| ROBOLECTRIC_MIGRATION=DeprecatedMethods ./gradlew clean :compileDebugUnitTestJava | ||
| ROBOLECTRIC_MIGRATION=ShadowUsageCheck ./gradlew clean :compileDebugUnitTestJava | ||
| ROBOLECTRIC_MIGRATION=DeprecatedMethods,ShadowUsageCheck ./gradlew clean :compileDebugUnitTestJava |
There was a problem hiding this comment.
It seems that it is now possible to pass multiple checks at once. See https://errorprone.info/docs/patching
utzcoz
approved these changes
Sep 22, 2024
|
Looks like no-one has tried this errorprone tool for migration recent years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Automated Migration page.
The changes are: