Update the "Best Practices & Limitations" page #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the [Best Practices & Limitations](https://robolectric.org/best-practices/) page. It adds links to external documentation where possible. It also simplifies the `Customizing the Test Runner` page, since most of the documentation is on Hilt side.
utzcoz
approved these changes
Sep 4, 2024
|
Thanks for the review @utzcoz. The Do you think it makes sense to keep it, considering the small amount of information it provides? |
|
I still want to keep this page. Beside of current di configuration hint, we also can support more content related to test runner customization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Best Practices & Limitations page.
It adds links to external documentation where possible.
It also simplifies the Customizing the Test Runner page, since most of the documentation is on Hilt side. I feel that this page does no longer bring any useful information. Does it make sense to keep it? It used to have more, but it was mainly for RoboGuice.
If we remove it, the Build System Integration page could go in the "User Guide" section instead.