-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 👷 pypi username - password swap with token #1542
Conversation
Signed-off-by: Onuralp SEZER <[email protected]>
As discussed privately, we'll instead set this up with Trusted Providers. @onuralpszr , we now have the publishers set up on PyPi. We can proceed with changing the code. |
Are we going to use single file or both files (change trigger control done via "release") ? |
We've added 2 publishers. One for release via |
Why do both files have a "🚀 Publish to Test-PyPi" and "🚀 Publish to PyPi"? Should it not be one for each? |
Current setup pre-release versions goes to pypi and pypi-test server |
So publish-test isn't actually for test, but for pre-release. Can we add a comment in the file? This isn't automatically obvious for someone new to the system. |
178f461
to
fbb5778
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving prremptively with small changes incoming as agreed in a separate conversation
Signed-off-by: Onuralp SEZER <[email protected]>
fbb5778
to
31a3cca
Compare
Description
Pypi username / password has been replaced to with pypi token