Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 👷 pypi username - password swap with token #1542

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

onuralpszr
Copy link
Collaborator

Description

Pypi username / password has been replaced to with pypi token

@onuralpszr onuralpszr added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Sep 24, 2024
@onuralpszr onuralpszr self-assigned this Sep 24, 2024
@LinasKo
Copy link
Collaborator

LinasKo commented Sep 26, 2024

As discussed privately, we'll instead set this up with Trusted Providers.

@onuralpszr , we now have the publishers set up on PyPi. We can proceed with changing the code.

@onuralpszr
Copy link
Collaborator Author

onuralpszr commented Sep 26, 2024

As discussed privately, we'll instead set this up with Trusted Providers.

@onuralpszr , we now have the publishers set up on PyPi. We can proceed with changing the code.

Are we going to use single file or both files (change trigger control done via "release") ?

@LinasKo
Copy link
Collaborator

LinasKo commented Sep 27, 2024

Are we going to use single file or both files (change trigger control done via "release") ?

We've added 2 publishers. One for release via publish.yml and one for test, via publish-test.yml.

@LinasKo
Copy link
Collaborator

LinasKo commented Sep 27, 2024

Why do both files have a "🚀 Publish to Test-PyPi" and "🚀 Publish to PyPi"? Should it not be one for each?

@onuralpszr
Copy link
Collaborator Author

onuralpszr commented Sep 27, 2024

Why do both files have a "🚀 Publish to Test-PyPi" and "🚀 Publish to PyPi"? Should it not be one for each?

Current setup

pre-release versions goes to pypi and pypi-test server
release version goes to pypi and pypi-test server

@LinasKo
Copy link
Collaborator

LinasKo commented Sep 27, 2024

So publish-test isn't actually for test, but for pre-release. Can we add a comment in the file? This isn't automatically obvious for someone new to the system.

@onuralpszr onuralpszr force-pushed the ci/pypi-configs branch 2 times, most recently from 178f461 to fbb5778 Compare September 27, 2024 12:46
Copy link
Collaborator

@LinasKo LinasKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving prremptively with small changes incoming as agreed in a separate conversation

@LinasKo LinasKo merged commit 1860fdb into develop Sep 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants