Check that responsejson is instance of dict #342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current error handling of
rfapi.py
implies thatresponsejson
is always a dict, however this seems to not be the case and fails without recourse whenresponsejson
is a string.Therefore, the condition should not only check that
responsejson
exists, but rather if it is a instance of adict
, since under the condition, it uses methods that are only valid on dictionaries.This does not change any behavior as the
else
statement will return the response as a string regardless.Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested local example, ran full test suite including
test_rfapi.py
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs