docs: set LOAD_ENTERPRISE_BLOCKS=TRUE in docs workflow build step#2386
Open
rvirani1 wants to merge 2 commits into
Open
docs: set LOAD_ENTERPRISE_BLOCKS=TRUE in docs workflow build step#2386rvirani1 wants to merge 2 commits into
rvirani1 wants to merge 2 commits into
Conversation
Without this flag, the block-enumeration loader silently drops every enterprise block, so the docs CI never generates pages for them and links from the frontend 404. The workflow already checks out and installs the private workflows-enterprise-blocks repo; this just makes the build step actually load them. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rvirani1
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
hansent,
probicheaux,
rafel-roboflow and
yeldarby
as code owners
get_source_link_for_block_class only handled inference/core/workflows/, so enabling enterprise blocks produced pages with href="None" (the split raised IndexError and the link fell back to None). Resolve the path relative to the inference package root instead, so both core (inference/core/workflows/...) and enterprise (inference/enterprise/workflows/...) blocks get valid links. Core-block links are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Bug 1 from ENT-1295 (enterprise block doc pages never generated) in two parts:
.github/workflows/docs.yml: the docs CI checks out and pip installs the privateworkflows-enterprise-blocksrepo, but the "Build block docs" step never setLOAD_ENTERPRISE_BLOCKS, soblocks_loader.pysilently dropped every enterprise block and no page was generated (links 404). Now setsLOAD_ENTERPRISE_BLOCKS: "TRUE"on that step.development/docs/build_block_docs.py: with enterprise blocks now loaded,get_source_link_for_block_classonly handledinference/core/workflows/, so enterprise pages gothref="None". It now resolves the path relative to theinferencepackage root, producing valid links for both core (inference/core/workflows/…) and enterprise (inference/enterprise/workflows/…) blocks. Core-block links are unchanged.After merge, trigger the workflow with
deploy: true(or cut a release) to regenerate and publish. Bug 2 (frontend slugifier mismatch for OPC UA and 6 other names) is handled separately in theroboflowrepo.Test plan
deploy: true; confirmopcua_writer_sink,mqtt_writer,event_writer,plc_modbus_tcppages resolve and their "Source" links point to valid GitHub URLs (notNone).