Adding singleRecord and averageRecord to Result's schema #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ViniRoveri Problem is that all result json files will need to be rebuilt then :). I was trying to avoid that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! It's me again lol
I noticed that you added the singleRecord and averageRecord properties when creating the Result object to count the amount of records of a person, but I thought it was also very helpful to have this data on the api as well when getting a result!
So I just added these fields to the json serialization function, and to the api documentation already as well
Also, I didn't add anything about these changes to the tests, cause it's fair that you do so the way you feel the most confortable
Cheers!