Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP]More flexible way to setup vhosts #20

Merged
merged 5 commits into from
Sep 24, 2023

Conversation

flotho
Copy link
Contributor

@flotho flotho commented Jul 25, 2023

No description provided.

@flotho
Copy link
Contributor Author

flotho commented Jul 25, 2023

Hi @robertdebock , hope you're doing well.
I would like to share here a PR for a review.
My idea is to provide the ability to admin sys to setup easily different use cases.
First I added a way to provide multiple reverse proxies URL here https://github.com/robertdebock/ansible-role-httpd/pull/20/files#diff-a2271dae58ad9bbc44098c6b923a6f9a118a96a9885a65b6fd057e96b4d982d2R43

I also added a generic Key / Value iterable object that allow to pass almost anything https://github.com/robertdebock/ansible-role-httpd/pull/20/files#diff-a2271dae58ad9bbc44098c6b923a6f9a118a96a9885a65b6fd057e96b4d982d2R55. As you're testing syntax before the restart of the service, IMHO there is no major risk here.

Please tell me if it's a direction you could accept once the review process will be finished.

@flotho flotho changed the title WIP[IMP]More flexible way to setup vhosts [IMP]More flexible way to setup vhosts Aug 9, 2023
@flotho
Copy link
Contributor Author

flotho commented Aug 9, 2023

Hi @robertdebock , my first proposal was finally to messy.
I've restarted with a simplier way of working.
You ll find there a way for the admin to choose which template to inject.
This way, it's no more the responsability of your module to deal with all the cases of everyone. Your module provide the minimum process and specific cases could be handled outside your role.
Your feedback will be appreciated.
Regarsd

@robertdebock
Copy link
Owner

Good PR, thanks, I'll merge.

@robertdebock robertdebock merged commit eeee31a into robertdebock:master Sep 24, 2023
11 checks passed
@flotho flotho deleted the IMP-more-flexible-vhosts branch September 24, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants