Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #23
The question for me is whether the following line also needs to be adapted to the custom CLOCK_SOURCE.
libethercat/src/dc.c
Line 354 in 9108db1
The packet latency in
libethercat/src/dc.c
Lines 100 to 108 in 9108db1
also uses
osal_timer_gettime_nsec()
. In libosal for POSIX, CLOCK_REALTIME is currently used, which I think is not optimal, because it can be changed by NTP (see here). So, at least for Linux CLOCK_MONOTONIC is better.For measuring packet latency it doesn't matter which time reference is used, but for DC sync it is important if you want to synchronize the master rtc to an external clock, e.g. via PTP. In this case, you would prefer CLOCK_TAI.