Dockerize flask app, allow to download files from S3 from generated URLs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Signed-off-by: Denis Trofimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1 sentence tagline of what the PR includes.
Description of Task to be completed?
A detailed description of what the PR delivers.
all the salt is in commit messages:
30bbb2c (HEAD -> dockerize, origin/dockerize) ref: create a temporary directory using the context manager
631a11d ref: no download_file, use root web path since it is a one page app
3af3d6a feat: Serve static files in Flask from private AWS S3 bucket
55b22a5 feat: way to run in docker container
74698eb improvement: update python version 3.8
c13a9a3 feat: set bucket name passing env
f617f57 fix: should not mask errors
2c101ef fix: should run app with "flask run"
How should this be manually tested?
Steps on how to test the work delivered by the PR.
Any background context you want to provide?
Any additional information, configuration or data that might be necessary to a
reviewer of the PR.
What are the relevant issues?
Reference the issue if applicable.
Screenshots (if appropriate)
Questions: