Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: events in bridgeless mode #3656

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

WoLewicki
Copy link
Contributor

@WoLewicki WoLewicki commented Oct 11, 2024

PR concerning New Architecture support in the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on [email protected]


Description

Fixes events on bridgeless mode on Android in new arch. The naming convention is more strict there and events have to follow the convention of on<Event> to top<Event> naming.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Just run the example app on new arch now, I removed the bridgelessEnabled=false flag since bridgeless mode is the default and recommended option.

@mfazekas mfazekas merged commit 2980630 into main Oct 13, 2024
11 checks passed
@mfazekas mfazekas deleted the @wolewicki/fix-events-in-bridgeless branch October 13, 2024 10:38
@mfazekas
Copy link
Contributor

@WoLewicki amazing, thanks much for looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants