Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce the 'flyAndZoomTo' event #3639

Closed
wants to merge 1 commit into from

Conversation

boazpoolman
Copy link

Description

Added flyAndZoomTo that allows both the zoomTo and flyTo events to be fired as a single animation.

Checklist

I have not updated any documentation just yet, as I wanted to confirm that the maintainers of this package agree with the implementation decisions. For example, the leaflet flyTo event just allows an extra parameter if you'd also want to handle zoom (source). We could do the same thing for this package, but to prevent a breaking change the zoomLevel would have to become the 3rd parameter of the flyTo function, after animationDuration, which is not in line with the other events which all have the animationDuration as the last and optional param.

Please let me know if you agree with this PR, or if you'd like me to make any changes.

@mfazekas
Copy link
Contributor

mfazekas commented Oct 6, 2024

@boazpoolman thanks much for the PR,

Question: so we already have setCamera that allows one to set multiple things. What's the advantage of flyAndZoomTo ?

@boazpoolman
Copy link
Author

I completely looked over the setCamera event.
Let me test this quickly this week. Sounds like this PR can be closed.

@boazpoolman
Copy link
Author

Yep. The setCamera event does exactly what I need.
Didn't do my research properly, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants