Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement interfaces in Android sources #3135

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

WoLewicki
Copy link
Contributor

@WoLewicki WoLewicki commented Oct 24, 2023

PR adding New Architecture support to the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on [email protected]


Notes

PR fixing not implemented interfaces in Source components, adding not implemented setters for existing and removing unused images and nativeImages props

@WoLewicki
Copy link
Contributor Author

@mfazekas is there a reason on some Source components, the existing prop was not implemented in managers?

@mfazekas
Copy link
Contributor

@mfazekas is there a reason on some Source components, the existing prop was not implemented in managers?

It was an overlook, existing should be there for other sources. Just that are mostly used in practice for ShapeSource.

@WoLewicki
Copy link
Contributor Author

@mfazekas this one also looks ready now 🚀

@mfazekas mfazekas merged commit 7ed9e28 into main Oct 25, 2023
9 checks passed
@mfazekas mfazekas deleted the @wolewicki/fix-android-sources branch October 25, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants