Add biome-color deprecation notice message, pretty-up update-availabl…

…e notification (#80)

src/main/java/dev/rndmorris/salisarcana/CommonProxy.java

@@ -28,7 +28,8 @@
 import dev.rndmorris.salisarcana.config.settings.CommandSettings;
 import dev.rndmorris.salisarcana.lib.ResearchHelper;
 import dev.rndmorris.salisarcana.network.NetworkHandler;
-import dev.rndmorris.salisarcana.updater.Updater;
+import dev.rndmorris.salisarcana.notifications.StartupNotifications;
+import dev.rndmorris.salisarcana.notifications.Updater;
 
 public class CommonProxy {
 
@@ -44,6 +45,9 @@ public void preInit(FMLPreInitializationEvent event) {
         FMLCommonHandler.instance()
             .bus()
             .register(new Updater());
+        FMLCommonHandler.instance()
+            .bus()
+            .register(new StartupNotifications());
     }
 
     // load "Do your mod setup. Build whatever data structures you care about. Register recipes." (Remove if not needed)

src/main/java/dev/rndmorris/salisarcana/config/modules/BiomeColorModule.java

@@ -4,16 +4,26 @@
 
 import dev.rndmorris.salisarcana.config.ConfigPhase;
 import dev.rndmorris.salisarcana.config.settings.BiomeColorsSettings;
+import dev.rndmorris.salisarcana.config.settings.ToggleSetting;
 
 public class BiomeColorModule extends BaseConfigModule {
 
+    public final ToggleSetting acknowledgeDeprecation;
+
     public final BiomeColorsSettings eerie;
     public final BiomeColorsSettings eldritch;
     public final BiomeColorsSettings magicalForest;
     public final BiomeColorsSettings taint;
 
     public BiomeColorModule() {
         addSettings(
+            acknowledgeDeprecation = (ToggleSetting) new ToggleSetting(
+                this,
+                ConfigPhase.LATE,
+                "acknowledgeDeprecation",
+                "Set to true to acknowledge that the biome color module is being deprecated, and silence the warning message.")
+                    .setEnabled(false)
+                    .setCategory("_notices"),
             eerie = new BiomeColorsSettings(
                 this,
                 ConfigPhase.EARLY,
@@ -61,6 +71,6 @@ public String getModuleId() {
     @Nonnull
     @Override
     public String getModuleComment() {
-        return "Override the colors of TC4's biomes.";
+        return "Notice: This is broken for some users, and slated for removal in a future update.\nOverride the colors of TC4's biomes.";
     }
 }

src/main/java/dev/rndmorris/salisarcana/notifications/StartupNotifications.java

@@ -0,0 +1,24 @@
+package dev.rndmorris.salisarcana.notifications;
+
+import net.minecraft.util.ChatComponentTranslation;
+
+import cpw.mods.fml.common.eventhandler.SubscribeEvent;
+import cpw.mods.fml.common.gameevent.PlayerEvent;
+import dev.rndmorris.salisarcana.config.ConfigModuleRoot;
+
+public class StartupNotifications {
+
+    private boolean noticeSent = false;
+
+    @SubscribeEvent
+    public void onLogin(PlayerEvent.PlayerLoggedInEvent event) {
+        final var biomeColors = ConfigModuleRoot.biomeColors;
+        if (noticeSent || !biomeColors.isEnabled() || biomeColors.acknowledgeDeprecation.isEnabled()) {
+            return;
+        }
+        noticeSent = true;
+        event.player.addChatMessage(new ChatComponentTranslation("salisarcana:biome_color_deprecation"));
+        event.player.addChatMessage(new ChatComponentTranslation("salisarcana:biome_color_deprecation_suppress"));
+    }
+
+}

src/main/java/dev/rndmorris/salisarcana/updater/Updater.java → src/main/java/dev/rndmorris/salisarcana/notifications/Updater.java

@@ -1,4 +1,4 @@
-package dev.rndmorris.salisarcana.updater;
+package dev.rndmorris.salisarcana.notifications;
 
 import static dev.rndmorris.salisarcana.SalisArcana.LOG;
 
@@ -37,9 +37,9 @@ public void onLogin(PlayerEvent.PlayerLoggedInEvent event) {
             hasCheckedVersion = true;
             VersionInfo newVersion = checkForNewVersion();
             if (newVersion != null) {
-                IChatComponent message = new ChatComponentTranslation(
-                    "salisarcana:update_available",
-                    newVersion.getVersionNumber());
+                event.player.addChatMessage(
+                    new ChatComponentTranslation("salisarcana:update_available", newVersion.getVersionNumber()));
+                IChatComponent message = new ChatComponentTranslation("salisarcana:update_link");
                 message.getChatStyle()
                     .setChatClickEvent(
                         new ClickEvent(

src/main/resources/assets/salisarcana/lang/en_US.lang

@@ -110,7 +110,10 @@ salisarcana:error.unexpected_value=Unexpected input "%s".
 salisarcana:error.unknown_value=Unknown value "%s".
 salisarcana:error.unknown_research=%s is not a known research key.
 
-salisarcana:update_available=A new version of Salis Arcana is available (%s). Click here to open the download page.
+salisarcana:biome_color_deprecation=§eNotice:§r The biome colors module is broken for some users, and slated for removal in a future update.
+salisarcana:biome_color_deprecation_suppress= Set §7acknowledgeDeprecation§r to §7true§r in §7salisarcana/biome_colors.cfg§r to suppress this warning.
+salisarcana:update_available=A new version of Salis Arcana is available (%s). 
+salisarcana:update_link= §9Click here to open the download page.§r
 
 tc.research_name.CAP_iron=Iron Wand Caps
 tc.research_name.ROD_wood=Wooden Wand Core