Mochammad Sidiq Tri S #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added page for 404, added about page
dhimashary
reviewed
Dec 14, 2020
| import axios from 'axios' | ||
| import router from '../router' | ||
|
|
||
| const baseUrl = 'https://bukatoko-server.herokuapp.com' |
There was a problem hiding this comment.
ini mending axiosnya pake axios instance
dhimashary
reviewed
Dec 14, 2020
src/store/index.js
Outdated
| errMessage: '' | ||
| }, | ||
| mutations: { | ||
| getData (state, data) { |
|
karena navbar dan footer ada di setiap views, setiap ganti halaman navbar dan footernya bakal re render lho padahal sama aja navbar sama footernya. coba dipikirkan apakah ada cara lain untuk handle ini ? |
dhimashary
reviewed
Dec 14, 2020
src/views/Home.vue
Outdated
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr v-for="data in productData" :key="data.id" class="overflow-y-auto"> |
There was a problem hiding this comment.
ini bisa jadi reusable component lagi kan, misal ProductTableRow
dhimashary
reviewed
Dec 14, 2020
src/views/Home.vue
Outdated
| <v-simple-table> | ||
| <thead> | ||
| <tr> | ||
| <th |
There was a problem hiding this comment.
ini bisa jadi reusable component lagi kan, misal ProductTableHead
|
footer masih terbang , ga nempel di bawah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
email admin: [email protected]
pass: 123456