Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish ProducerOrigin implementation #266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Finish ProducerOrigin implementation #266

wants to merge 2 commits into from

Conversation

sudipghimire533
Copy link
Contributor

  • Bring ProducerOrigin of pallet_rmrk_core::Config into use inside mint_nft, mint_nft_directly_to_nft and create_collection.
  • Default to EnsureSigned to make no logical change into how chain works

@sudipghimire533 sudipghimire533 changed the title Add cfg attribute to runtime-benchmark Helper in pallet_equip Finish ProducerOrigin implementation Jan 17, 2023
@HashWarlock
Copy link
Contributor

Can you add some tests for this? I'm still a little unsure on this functionality. If the runtime doesn't add accounts to the T:ProtocolOrigin then anyone can call mint_nft, mint_nft_directly_to_nft and create_collection?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudipghimire533 @HashWarlock