Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates master from dev #273

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
45189e8
Improvement on RMRKTokenHolder implementation and IERC7401 docs.
steven2308 Mar 3, 2024
02e5c0e
Bumps version to 2.5.1.
steven2308 Mar 3, 2024
af883ca
Refactor on token attributes to reuse code and allow multiple collect…
steven2308 Mar 1, 2024
ce9db7e
Changes on RMRKTokenAttributes.
steven2308 Mar 5, 2024
7c9d05d
Adds methods to get and set attributes metadata for a collection.
steven2308 Mar 5, 2024
b00fd30
Bumps version to 2.5.2.
steven2308 Mar 8, 2024
a5641f4
Bump squirrelly from 8.0.8 to 9.0.0
dependabot[bot] Mar 1, 2024
ce6791b
Bump follow-redirects from 1.15.5 to 1.15.6
dependabot[bot] Mar 17, 2024
eb8c79e
Includes token attributes for signed ints and refactors interface.
steven2308 Mar 15, 2024
8794912
Renames Issuer for Owner in token attributes.
steven2308 Mar 15, 2024
2e15e78
Adds full test coverage for token attributes.
steven2308 Mar 15, 2024
7c28817
Sorts methods on RMRKTokenAttributesRepository.
steven2308 Mar 15, 2024
cae5f2b
Reorders methods on token attributes repo implemention.
steven2308 Mar 15, 2024
01c04a9
Bumps version to 2.5.3.
steven2308 Mar 19, 2024
9203a7b
Updates docs on attributes repo.
steven2308 Mar 19, 2024
3e72f33
Merge branch 'master' into dev
steven2308 Mar 19, 2024
c2b2d8e
Improves dev comment on token holder implementation.
steven2308 Mar 19, 2024
f7cb8f2
Adds Astar zkEVM.
steven2308 Mar 19, 2024
744c1d8
Can get asset metadata with no specific token by using tokenId 0.
steven2308 Mar 21, 2024
aa7c8b7
Fixes typo on hardhat config.
steven2308 Mar 21, 2024
6178c7e
Bumps version to 2.5.4.
steven2308 Mar 21, 2024
2b2ab4e
Makes RMRKTokenHolder methods public instead of external
steven2308 Apr 10, 2024
b1f9832
Minor config fixes.
steven2308 Apr 10, 2024
8babe32
Makes getAssetMetadata implementation on AbstractMultiAsset virtual.
steven2308 Apr 10, 2024
d175ab9
Bumps version to 2.5.5.
steven2308 Apr 10, 2024
2c11b48
Implements BulkWriter.transferAndEquip.
steven2308 Apr 19, 2024
0a58afa
Fix on catalog factory, transfer ownership to deployer.
steven2308 Apr 29, 2024
0394ffe
Adds RmrkEquippable version where children are directly accepted.
steven2308 Jun 17, 2024
789ed4b
Bumps version to 2.5.6.
steven2308 Jun 17, 2024
f338913
Merge branch 'dev'
steven2308 Jan 7, 2025
e3d55b6
Updates changelog.
steven2308 Jan 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ MUMBAI_URL=
BASE_GOERLI_URL=
BASE_SEPOLIA_URL=
SHIBUYA_URL=
ZKATANA_URL=
ZKYOTO_URL=
IMMUTABLE_TEST_URL=

# Mainnet networks
Expand All @@ -15,6 +15,7 @@ ETHEREUM_URL=
POLYGON_URL=
BASE_URL=
ASTAR_URL=
ASTAR_ZK_URL=
BSC_URL=

# To verify contracts
Expand All @@ -23,7 +24,8 @@ MOONSCAN_APIKEY=ABC123
POLYGONSCAN_API_KEY=ABC123
BASESCAN_API_KEY=ABC123
ASTAR_BLOCKSCOUT_API_KEY=ABC123
ZKATANA_BLOCKSCOUT_API_KEY=ABC123
ASTAR_ZK_API_KEY=
ZKYOTO_BLOCKSCOUT_API_KEY=ABC123
BSCSCAN_API_KEY=ABC123
IMMUTABLE_BLOCKSCOUT_API_KEY=ABC123

Expand Down
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,25 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [2.5.6] - 2024-06-17

### Added

- RMRKMinifiedEquippableChildAutoAcceptMock. Which bypasses accepting children.

## [2.5.5] - 2024-04-10

### Changed

- getAssetMetadata core implementation is now virtual.
- RMRKTokenHolder methods are made public instead of external.

## [2.5.4] - 2024-03-21

### Changed

- getAssetMetadata core implementation can now return the metadata disregarding tokenId by setting it to 0.

## [2.5.3] - 2024-03-19

### Changed
Expand Down
2 changes: 1 addition & 1 deletion contracts/RMRK/core/RMRKCore.sol
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pragma solidity ^0.8.21;
* @dev This is currently just a passthrough contract which allows for granular editing of base-level ERC721 functions.
*/
contract RMRKCore {
string private constant _VERSION = "2.5.3";
string private constant _VERSION = "2.5.6";
bytes4 private constant _RMRK_INTERFACE = 0x524D524B; // "RMRK" in ASCII hex

/**
Expand Down
6 changes: 4 additions & 2 deletions contracts/RMRK/equippable/RMRKMinifiedEquippable.sol
Original file line number Diff line number Diff line change
Expand Up @@ -1280,8 +1280,10 @@
function getAssetMetadata(
uint256 tokenId,
uint64 assetId
) public view virtual returns (string memory metadata) {
if (!_tokenAssets[tokenId][assetId]) revert RMRKTokenDoesNotHaveAsset();
) public view virtual override returns (string memory metadata) {
// Allow to get the asset metadata without a token having it:
if (tokenId != 0 && !_tokenAssets[tokenId][assetId])
revert RMRKTokenDoesNotHaveAsset();
Comment on lines +1285 to +1286

Check notice

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.
metadata = _assets[assetId];
}

Expand Down
Loading
Loading