Repository navigation
Fix parser source locations after multibyte input - #5771
Merged
Merged
Conversation
Owner
|
Thanks for fixing this! Does the C Parser need a fix for this too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser receives byte offsets from the lexer, but cached newline positions used character offsets. Multibyte comments and strings could therefore shift AST locations and validation errors. AST columns also differed from character-based parse error columns.
Store newline positions as byte offsets and count UTF-8 characters within the containing line. Correct the final-line calculation when the input has no trailing newline.