Repository navigation
Fix reversed time in spec - #5768
Merged
Merged
Conversation
`started_at_2 - ended_at_2` is negative; assert_in_delta compares the absolute difference, so it passed, but it read backwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dpep
force-pushed
the
fix-async-dataloader-parallel-test
branch
from
October 5, 2026 00:15
85ad742 to
7cebbfc
Compare
dpep
changed the title
dpep
changed the title
dpep
marked this pull request as ready for review
October 5, 2026 00:21
Owner
|
Fair enough! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the AsyncDataloader "works with sources" spec, the "Already-loaded values returned instantly" check computed
started_at_2 - ended_at_2, which is a negative duration.assert_in_deltacompares the absolute difference, so it passed, but it read backwards. This swaps it toended_at_2 - started_at_2.It's test-only, with no change to what passes. The spec still passes, and rubocop is clean.