New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve built-in Rails support for Dataloader #5213

Open

rmosolgo wants to merge 3 commits into master from rails-dataloader

+329 −6

Owner

rmosolgo commented Jan 24, 2025 •

edited

Loading

I was helping someone move database access to Dataloader and decided that some of the "boilerplate" could be shipped with the gem:

Record and Association source classes
- Check for already-loaded associations before pausing the Fiber
ActiveStorage sources, others?
Helper methods for built-in sources
A cop to spot possible dataloader-friendly accesses
Field config helpers to automatically call dataload helpers (eg dataload_association: true)
Would enabling ActiveRecord Strict mode help catch these missing batch loads?
Add trace hooks for dataloader sources

rmosolgo added 3 commits

January 18, 2025 10:33


          Add ActiveRecordSource

569f58e


          Add ActiveRecordAssociationSource

d036245


          Add HasDataloader

e2c45a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet