Refactor reducer to enable testing #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separating ourselves from the concrete implementation of the CacheHelper via an interface makes it easier to write tests against RepoReducer.
The lang option never gets used anywhere (and is not even hooked up as a proper argument!) so we can safely prune it.
All of the uses of the reducer have the exact same sequence. We can capture this sequence and then use it as our model for testing the reducer.
This is the first step in de-couple the repo data loading from the reducer itself to enable easier testing of the reducer.
In order to completely decouple the loading process from the general reducer algorithm we need to decouple it from the RepoReducer itself. This change converts to returning the package list and accepting the inputs as parameters to enable this decoupling.
RepoLoader captures the repository package loading process separately from the reducer and introduces an interface between them to make testing the reducer easier.
kellyma2
force-pushed
the
reducer-refactor
branch
from
e9b412e to
325d64d
Compare
|
LGTM, I guess tests will be added later. I wonder what that lang variable was for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current iteration of the reducer is a bit difficult to test for a few reasons:
This PR aims to ameliorate these difficulties by disentangling some of the couple via a separate loader and generic interfaces while also codifying the workflow of the reducer in a single place to make it obvious how it's used