Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround bug in macOS 14.4.1 and later where encoding HEIC fails #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Workaround bug in macOS 14.4.1 and later where encoding HEIC fails #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion EquinoxCore/EquinoxCore/Cores/ImageCore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,22 @@ public final class ImageCoreImpl: ImageCore {
progressCallback: ProgressCallback?
) throws -> Data {
let mutableData = NSMutableData()
let options = [kCGImageDestinationLossyCompressionQuality: 1.0] as CFDictionary
let destinationType = AVFileType.heic as CFString
let lossyCompressionQuality: Double

// Workaround bug in macOS 14.4.1 and later where encoding HEIC fails.
//
// See https://github.com/rlxone/Equinox/issues/66
//
// TODO: Verify exact affected versions (start and end).
if #unavailable(macOS 14.4.1) {
lossyCompressionQuality = 1
} else {
// Almost, but not exactly lossless.
lossyCompressionQuality = 0.9999999
}

let options = [kCGImageDestinationLossyCompressionQuality: lossyCompressionQuality] as CFDictionary

guard let destination = CGImageDestinationCreateWithData(mutableData, destinationType, attributes.count, nil) else {
throw ImageError.destinationNotCreated
Expand Down