Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PER #2159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add PER #2159

wants to merge 1 commit into from

Conversation

maliesa96
Copy link
Contributor

Closes #1489.

@maliesa96 maliesa96 requested a review from a team as a code owner October 28, 2020 22:39
@maliesa96 maliesa96 requested review from ryanjulian and removed request for a team October 28, 2020 22:39
@mergify mergify bot requested review from a team, yeukfu and ziyiwu9494 and removed request for a team October 28, 2020 22:39
@maliesa96
Copy link
Contributor Author

Benchmarks should be done in a few days.

@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.23529% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.52%. Comparing base (e1c576f) to head (8f3fb8e).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
src/garage/torch/algos/dqn.py 61.53% 4 Missing and 1 partial ⚠️
src/garage/torch/algos/pearl.py 0.00% 2 Missing ⚠️
src/garage/replay_buffer/per_replay_buffer.py 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
- Coverage   91.56%   91.52%   -0.04%     
==========================================
  Files         197      198       +1     
  Lines       10927    10979      +52     
  Branches     1387     1393       +6     
==========================================
+ Hits        10005    10049      +44     
- Misses        663      669       +6     
- Partials      259      261       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ryanjulian
ryanjulian reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@ryanjulian ryanjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the benchmark results?

krzentner
krzentner approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@krzentner krzentner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is a pretty clean implementation.

src/garage/replay_buffer/per_replay_buffer.py Outdated Show resolved Hide resolved
src/garage/torch/algos/dqn.py Outdated Show resolved Hide resolved
@maliesa96 maliesa96 force-pushed the per_dqn branch 2 times, most recently from 4e708fd to bf2b104 Compare November 6, 2020 19:37
@maliesa96
Copy link
Contributor Author

Currently rerunning some of the benchmarks (some were interrupted), will report back once they're done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzentner krzentner krzentner approved these changes

@ryanjulian ryanjulian ryanjulian left review comments

@yeukfu yeukfu Awaiting requested review from yeukfu

@ziyiwu9494 ziyiwu9494 Awaiting requested review from ziyiwu9494

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PER
3 participants
@maliesa96 @ryanjulian @krzentner