Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

MAINT: Python 3 compatibility and travis testing #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matthew-brett
Copy link

Use futurize and some hand editing to update code for Python3.

Add .travis.yml file for travis-ci testing.

Use ``futurize`` and some hand editing to update code for Python3.

Add .travis.yml file for travis-ci testing.
Python 3 port assumes that input is always binary, and converts to
latin1 before running regex.
@matthew-brett
Copy link
Author

Sorry, I didn't notice #1 before I did this.

Here I took the approach of always opening files in binary mode, and converting to latin1 before doing the regex searches. I guess that is what grin is doing, effectively, under Python 2, but I'm happy to be corrected.

@rgommers
Copy link

Just started on the same thing - glad I checked here first. Thanks @matthew-brett and @jvkersch.

I tested both PRs, both work as expected for my use cases.

rsalmaso added a commit to rsalmaso/grin3 that referenced this pull request Apr 19, 2017
@rgommers
Copy link

rgommers commented May 3, 2019

@rkern perhaps you can hit the green button here? Would make installing a lot easier ....

@matthew-brett
Copy link
Author

I still think this is the right fix - and this appears to be the last man standing. Robert - what do you think? I'm using this branch fairly often on my machines.

@jonathanrocher
Copy link

I just tested this out on Python3.6 and it worked seemlessly. @rkern any bandwidth to take a look?

@jonathanrocher
Copy link

@matthew-brett : @rkern commented offline that he won't be maintaining this repository anymore, and has switched to using https://github.com/BurntSushi/ripgrep . That implementation is amazing (and very fast) but is non-trivial to install for Windows users. Would you consider merging your branch into your fork's master, so a py3 supported version exists in a master branch somewhere?

@matthew-brett
Copy link
Author

@rkern - would you mind giving me upload rights to PyPI, user matthew.brett, so I can upload the Python 3 version? I'm happy to take responsibility for any errors I've introduced.

@itziakos
Copy link

itziakos commented Dec 2, 2020

There might be a new release of grin soon (#4)

@matthew-brett
Copy link
Author

@itziakos - do you know something we don't? Yes, a new release would be great.

@itziakos
Copy link

itziakos commented Dec 2, 2020

@itziakos - do you know something we don't? Yes, a new release would be great.

oops, I was actually trying to reference your comment and added my comment here by mistake. I do not have any additional information. Sorry for the confusion.

@matthew-brett
Copy link
Author

@itziakos - no problem - just hoping that you'd heard some news :)

@rkern
Copy link
Owner

rkern commented Dec 2, 2020

@matthew-brett Invitation sent. When you have your fork set up, I'll lock this one. Thank you!

@matthew-brett
Copy link
Author

Thanks Robert - invitation accepted. I have a fork with a master branch - is there something else I should do?

@rkern
Copy link
Owner

rkern commented Dec 3, 2020

You'll want to update the metadata and URLs in the setup.py and README.

@matthew-brett
Copy link
Author

matthew-brett commented Dec 3, 2020 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants