-
Notifications
You must be signed in to change notification settings - Fork 16
MAINT: Python 3 compatibility and travis testing #4
base: master
Are you sure you want to change the base?
Conversation
Use ``futurize`` and some hand editing to update code for Python3. Add .travis.yml file for travis-ci testing.
Python 3 port assumes that input is always binary, and converts to latin1 before running regex.
Sorry, I didn't notice #1 before I did this. Here I took the approach of always opening files in binary mode, and converting to |
Just started on the same thing - glad I checked here first. Thanks @matthew-brett and @jvkersch. I tested both PRs, both work as expected for my use cases. |
@rkern perhaps you can hit the green button here? Would make installing a lot easier .... |
I still think this is the right fix - and this appears to be the last man standing. Robert - what do you think? I'm using this branch fairly often on my machines. |
I just tested this out on Python3.6 and it worked seemlessly. @rkern any bandwidth to take a look? |
@matthew-brett : @rkern commented offline that he won't be maintaining this repository anymore, and has switched to using https://github.com/BurntSushi/ripgrep . That implementation is amazing (and very fast) but is non-trivial to install for Windows users. Would you consider merging your branch into your fork's master, so a py3 supported version exists in a master branch somewhere? |
@rkern - would you mind giving me upload rights to PyPI, user |
|
@itziakos - do you know something we don't? Yes, a new release would be great. |
oops, I was actually trying to reference your comment and added my comment here by mistake. I do not have any additional information. Sorry for the confusion. |
@itziakos - no problem - just hoping that you'd heard some news :) |
@matthew-brett Invitation sent. When you have your fork set up, I'll lock this one. Thank you! |
Thanks Robert - invitation accepted. I have a fork with a master branch - is there something else I should do? |
You'll want to update the metadata and URLs in the |
Done, I think. I've left you as the 'author_email' and added myself as
'maintainer'.
|
Use
futurize
and some hand editing to update code for Python3.Add .travis.yml file for travis-ci testing.