Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use Feature::Compat::Try instead of Try::Tiny #717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leont
Copy link
Contributor

@Leont Leont commented Dec 9, 2022

This makes it «use feature 'try'» on perl 5.36 and up, and use Syntax::Feature::Try on older versions.

This makes it «use feature 'try'» on perl 5.36 and up, and use
Syntax::Feature::Try on older versions.
@rjbs
Copy link
Owner

rjbs commented Dec 9, 2022

I am pretty hesitant here. I think Dist::Zilla has never used experimental features, and I'm not sure I want to start now.

@Leont
Copy link
Contributor Author

Leont commented Dec 9, 2022

Fair enough, it can wait.

Would that make Syntax::Keyword::Try a better option?

@rjbs
Copy link
Owner

rjbs commented Dec 9, 2022

I don't know, because I'm not sure what the benefit of using this over Try::Tiny is, here. What are we getting?

@Grinnz
Copy link
Contributor

Grinnz commented Dec 9, 2022

Efficiency, ability to use return normally, avoidance of superglobals, similarity to the upcoming 'try' feature!

@Grinnz
Copy link
Contributor

Grinnz commented Dec 9, 2022

Just make sure to use Syntax::Keyword::Try not the unrelated Syntax::Feature::Try 😄

@karenetheridge
Copy link
Contributor

not the unrelated Syntax::Feature::Try

gah! I didn't realize that existed.. we should watch out for this.

@Leont
Copy link
Contributor Author

Leont commented Dec 10, 2022

Just make sure to use Syntax::Keyword::Try not the unrelated Syntax::Feature::Try smile

Yeah I keep confusing them, have to check the author to know which one I want

@rjbs rjbs force-pushed the main branch 10 times, most recently from 9361f28 to f825e3b Compare June 3, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants