Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Remove JSON #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove JSON #27

wants to merge 1 commit into from

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Apr 9, 2021

Remove all JSON-related features since it's not used by Rizin.

A first step to address rizinorg/rizin#274 (comment)

cc @thestr4ng3r @08a

@XVilka XVilka requested review from ret2libc, thestr4ng3r and a user April 9, 2021 09:22
@thestr4ng3r
Copy link
Member

Does rizin still work against this or does it need adjustments?

@XVilka
Copy link
Member Author

XVilka commented Apr 9, 2021

@thestr4ng3r 2 things still need it:

  • Panels configuration storage
  • JSON grep (just parsing JSON)

rizinorg/rizin#985

Copy link
Member

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to wait for all the stuff to be done.

@XVilka
Copy link
Member Author

XVilka commented Jul 10, 2022

@ret2libc any idea why this error appeared?

src/meson.build:43:0: ERROR: declare_dependency keyword argument 'link_whole' was of type array[SharedLibrary] but should have been array[BothLibraries | StaticLibrary | CustomTarget | CustomTargetIndex | Dependency]

@ret2libc
Copy link
Member

@ret2libc any idea why this error appeared?

src/meson.build:43:0: ERROR: declare_dependency keyword argument 'link_whole' was of type array[SharedLibrary] but should have been array[BothLibraries | StaticLibrary | CustomTarget | CustomTargetIndex | Dependency]

I think 0.63.0 became stricter. The manual actually says that link_whole should be a list, thus it should be:

sdb_whole_dep = declare_dependency(
-  link_whole: libsdb,
+  link_whole: [libsdb],
  include_directories: libsdb_inc,
)

@XVilka
Copy link
Member Author

XVilka commented Jul 11, 2022

@ret2libc didn't help, looking at the error message, the culprit seems in the value itself

@ret2libc
Copy link
Member

@ret2libc didn't help, looking at the error message, the culprit seems in the value itself

Right... my bad. Just wrap it in a if meson.is_subproject(). It's going to go away anyway and sdb_whole_dep is used only in rizin right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants