Force Function Rename #4703
Open
Force Function Rename #4703
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New function to forcefully rename a function. Multiple retries will be performed by adding a numeric suffix to function name until the number of retries max's out
brightprogrammer
requested review from
wargio,
XVilka,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
|
About canalysis.c:3336 TODO? |
wargio
reviewed
Nov 6, 2024
| * @return `false` otherwiese. | ||
| * | ||
| * @sa rz_analysis_function_force_rename | ||
| * */ | ||
| RZ_API bool rz_analysis_function_rename(RzAnalysisFunction *fcn, const char *name) { |
wargio
reviewed
Nov 6, 2024
| * | ||
| * @sa rz_analysis_function_rename | ||
| * */ | ||
| RZ_API const char *rz_analysis_function_force_rename(RzAnalysisFunction *fcn, const char *name) { |
wargio
reviewed
Nov 6, 2024
Comment on lines
+316
to
+329
| const char *final_name = strdup(name); | ||
| ut32 retries = 100; | ||
| ut32 suffix = 0; | ||
| while ((retries--) && !rz_analysis_function_rename(fcn, final_name)) { | ||
| if (final_name) { | ||
| free((void *)final_name); | ||
| final_name = NULL; | ||
| } | ||
|
|
||
| ut32 strsz = snprintf(NULL, 0, "%s_%u", name, suffix) + 1; | ||
| final_name = malloc(strsz); | ||
| snprintf((char *)final_name, strsz, "%s_%u", name, suffix++); | ||
| } | ||
| return retries ? fcn->name : NULL; |
There was a problem hiding this comment.
instead of doing retries, just do name_offset which is granted to be unique. also use rz_strf directly instead of calling snprintf.
ignore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function to forcefully rename an analysis function. Multiple retries will be performed by adding a numeric suffix to function name until the number of retries max's out
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...