Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-v5 enum names which are now supported by compatibility macros. #4690

Closed
wants to merge 3 commits into from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Oct 25, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Requires capstone-engine/capstone#2525

Test plan

...

Closing issues

...

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update also the Capstone commit

@XVilka
Copy link
Member

XVilka commented Oct 26, 2024

@Rot127 there is one more problem with the recent Capstone update - ARM uplifting for couple instructions on big-endian systems:

[XX] 153 ms   db/asm/arm_64 <asm> mrs x1, NZCV

-- <asm> mrs x1, NZCV <--- 01423bd5 ---> <IL>

-- IL

--- expected

+++ actual

@@ -1,1 +1,0 @@

-(set x1 (| (ite (var nf) (bv 64 0x80000000) (bv 64 0x0)) (| (ite (var zf) (bv 64 0x40000000) (bv 64 0x0)) (| (ite (var cf) (bv 64 0x20000000) (bv 64 0x0)) (ite (var vf) (bv 64 0x10000000) (bv 64 0x0))))))

-- disasm exit status: 0

-- IL exit status: 1

-- IL stderr

Invalid instruction of lifting not implemented.

[XX] 163 ms   db/asm/arm_64 <asm> msr NZCV, x1

-- <asm> msr NZCV, x1 <--- 01421bd5 ---> <IL>

-- IL

--- expected

+++ actual

@@ -1,1 +1,0 @@

-(seq (set nf (! (is_zero (& (var x1) (bv 64 0x80000000))))) (set zf (! (is_zero (& (var x1) (bv 64 0x40000000))))) (set cf (! (is_zero (& (var x1) (bv 64 0x20000000))))) (set vf (! (is_zero (& (var x1) (bv 64 0x10000000))))))

-- disasm exit status: 0

-- IL exit status: 1

-- IL stderr

Invalid instruction of lifting not implemented.

https://app.travis-ci.com/github/rizinorg/rizin/jobs/627495678#L4202

@Rot127
Copy link
Member Author

Rot127 commented Oct 26, 2024

Closed in favor of #4691

@Rot127 Rot127 closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants