Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac ci: Drop pkg-config install step #4685

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Oct 23, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

On mac builds, this pr drops the pkg-config install step because it's not necessary:

brew-install-pkg-config
(https://github.com/rizinorg/rizin/actions/runs/11477136912/job/31938591776#step:4:1)

Test plan

The drop is appropriate. All builds are green.

Closing issues

...

@XVilka XVilka merged commit 2e831b2 into rizinorg:dev Oct 23, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants