Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade build-osx-pkg build to macos-14 #4677

Merged
merged 9 commits into from
Oct 19, 2024
Merged

Upgrade build-osx-pkg build to macos-14 #4677

merged 9 commits into from
Oct 19, 2024

Conversation

kazarmy
Copy link
Member

@kazarmy kazarmy commented Oct 18, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

This pr updates the build-osx-pkg "Build OSX package" build to macos-14. The build runs the whole test suite as well so that an OSX package is not built if tests are failing.

Test plan

This upgrade is appropriate.

Closing issues

...

@kazarmy kazarmy marked this pull request as draft October 18, 2024 13:09
@kazarmy kazarmy marked this pull request as ready for review October 19, 2024 02:38
@kazarmy kazarmy merged commit 1a8b3c6 into rizinorg:dev Oct 19, 2024
40 checks passed
kazarmy added a commit to kazarmy/rizin that referenced this pull request Oct 22, 2024
@kazarmy
Revert "Upgrade build-osx-pkg build to macos-14 (rizinorg#4677)"
fc41829 
This reverts commit 1a8b3c6.
kazarmy added a commit that referenced this pull request Oct 23, 2024
@kazarmy
ci: Reinstate macos-meson-clang-tests build on macos-13 (#4682)
f641480 
* Revert "Upgrade build-osx-pkg build to macos-14 (#4677)"
* Revert "ci: Remove macos-12 build (#4676)"
* Upgrade macos builds to macos-13
* Add fetch-depth: 2 to build-osx-pkg build
* Add -Wno-deprecated-non-prototype flag to `macos-meson-clang-tests` build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka Awaiting requested review from XVilka XVilka is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazarmy @wargio