Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/xap: refactor the code up to rizin standard #4659

Merged
merged 5 commits into from
Oct 3, 2024
Merged

arch/xap: refactor the code up to rizin standard #4659

merged 5 commits into from
Oct 3, 2024

Conversation

wargio
Copy link
Member

@wargio wargio commented Oct 2, 2024

SQUASH ME

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Updates xap arch to use the latest api.

  • Fixes output using RzStrBuf directly.
    (Before)
    image
    (After)
    image
  • Removes useless global variable.

XVilka

This comment was marked as resolved.

@XVilka
Copy link
Member

XVilka commented Oct 3, 2024

After this one is merged, we also should update Rizin submodule in Cutter, there are quite a few fixes since the last time we did it. Initially I wanted to wait until MIPS, nanoMIPS, and Xtensa lands, but that could be done again after.

librz/arch/isa/xap/dis.c Outdated Show resolved Hide resolved
@XVilka XVilka changed the title Update XAP code to a proper level of decency arch/xap: refactor the code up to rizin standard Oct 3, 2024
@XVilka XVilka merged commit b96f355 into dev Oct 3, 2024
47 checks passed
@XVilka XVilka deleted the fix-xap branch October 3, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants