Add Xtensa arch support #4654
Open
Add Xtensa arch support #4654
+1,384
−38,218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
rz-test
RzBin
RzAnalysis
API
RzCore
RzParse
ELF
Mach-O
ARM
MIPS
RZIL
RzAsm-Disassembler
RzAsm-Assembler
Xtensa
labels
imbillow
force-pushed
the
xtensa-support
branch
3 times, most recently
from
59c467b
to
f970b38
Compare
|
Yes, though let's wait until the Capstone PRs are merged. |
imbillow
force-pushed
the
xtensa-support
branch
from
f970b38
to
b270fce
Compare
imbillow
force-pushed
the
xtensa-support
branch
from
8cf2762
to
06a1661
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
imbillow
force-pushed
the
xtensa-support
branch
from
67f95e2
to
8972dfc
Compare
imbillow
force-pushed
the
xtensa-support
branch
from
8972dfc
to
82320c9
Compare
imbillow
requested review from
kazarmy,
thestr4ng3r and
ret2libc
as code owners
XVilka
requested changes
Nov 5, 2024
| return 3; | ||
| case RZ_ANALYSIS_ARCHINFO_MAX_OP_SIZE: | ||
| return 6; | ||
| // case RZ_ANALYSIS_ARCHINFO_TEXT_ALIGN: |
| // case RZ_ANALYSIS_ARCHINFO_DATA_ALIGN: | ||
| // return 0; | ||
| case RZ_ANALYSIS_ARCHINFO_CAN_USE_POINTERS: | ||
| return true; |
| @@ -13,6 +13,7 @@ RUN | |||
|
|
|||
| NAME=xtensa stackframe | |||
| FILE=malloc://512 | |||
| BROKEN=1 | |||
There was a problem hiding this comment.
Please don't forget to fix it eventually
| @@ -444,7 +444,7 @@ a____ 16 32 64 x86.nasm LGPL3 X86 nasm assembler | |||
| a____ 16 32 64 x86.nz LGPL3 x86 handmade assembler | |||
| _dA__ 16 xap PD XAP4 RISC (CSR) | |||
| _dA__ 32 xcore BSD Capstone XCore disassembler (by pancake) | |||
| _dAe_ 32 xtensa GPL3 XTensa CPU | |||
| _dA_I 32 xtensa LGPL3 Capstone Xtensa disassembly plugin | |||
There was a problem hiding this comment.
Add yourself as the author maybe?
| } | ||
|
|
||
| void xtensa_disassemble_fini(XtensaContext *self) { | ||
| if (!self->insn) |
| // SPDX-FileCopyrightText: 2024 billow <[email protected]> | ||
| // SPDX-License-Identifier: LGPL-3.0-only | ||
|
|
||
| #ifndef RIZIN_XTENSA_H |
There was a problem hiding this comment.
Could use just RZ_XTENSA_H maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...