Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NIOS-II architecture #4457

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Remove NIOS-II architecture #4457

merged 1 commit into from
Apr 24, 2024

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Apr 22, 2024

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • It was untested and unused (not a single bug was reported in 10+ years)
  • It is a software architecture for use in FPGA, too niche and rarely used for firmware RE
  • It is deprecated by Linux kernel, GCC, QEMU, and so on: https://lore.kernel.org/qemu-devel/[email protected]/

Test plan

CI is green

Closing issues

Partially addresses #2704

@XVilka XVilka merged commit 9526b6c into dev Apr 24, 2024
47 checks passed
@XVilka XVilka deleted the asan-remove-nios branch April 24, 2024 12:11
@pelijah
Copy link
Contributor

pelijah commented Apr 25, 2024

You forgot to update README and labeler config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants