Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DWARF composite layout in stack #4008

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fix DWARF composite layout in stack #4008

merged 3 commits into from
Nov 29, 2023

Conversation

imbillow
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

closes #4005
closes #3845

...

XVilka
XVilka requested changes Nov 28, 2023
View reviewed changes
librz/util/vector.c Show resolved Hide resolved
@XVilka

This comment was marked as resolved.

Sign in to view
@XVilka

This comment was marked as resolved.

Sign in to view
imbillow
imbillow commented Nov 28, 2023
View reviewed changes
librz/include/rz_vector.h Outdated Show resolved Hide resolved
XVilka

This comment was marked as resolved.

Sign in to view

@XVilka XVilka merged commit 8b8d5c7 into dev Nov 29, 2023
46 of 47 checks passed
@imbillow imbillow deleted the dwarf-composite-fix branch December 4, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Assignees
No one assigned
Labels
API DWARF rz-test RzAnalysis RzBin RzType RzUtil
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DWARF composite layout in stack - problem parsing test_vector_swap SIGTRAP
2 participants
@imbillow @XVilka