-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable generation of inter-procedual control flow graph. #4001
Conversation
@Rot127 is missing the changes on the YAML file. |
0f89ede
to
0caf119
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Regarding this:
Our graph API is in very poor shape, to be honest. We should have better graph data structures, just plain graphs and "enriched" with metainformation that is ready for printing: #992 (see also #397) |
- Add doc string. - Check NULL graph. - Check for node not part of graph.
Your checklist for this pull request
Detailed description
Requires: rizinorg/rizin-testbins#134
Adds the ability to generate a inter-procedual control flow graph.
One thing to discuss before merge:
The graph uses
RzGraphNodeInfo
instead of a simpleRzGraphNode
. This wastes space (at least the twochar *
members) becauseiCFGs
will get enormous.But if the graph is supposed to be returned by
rz_core_graph
it is basically forced to use it. Using only the node prevents printing it. Which would only be annoying for testing.Test plan
Test added
Closing issues
None