Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all compile warnings #3550

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Fix all compile warnings #3550

merged 2 commits into from
Jun 2, 2023

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented Jun 2, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

@wargio
Copy link
Member

wargio commented Jun 2, 2023

../librz/bin/filter.c:9:13: error: variable ‘bo’ set but not used [-Werror=unused-but-set-variable]
    9 |         ut8 bo[0x100];

Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

../librz/bin/filter.c
../librz/bin/filter.c: In function ‘false_positive’:
../librz/bin/filter.c:9:13: error: variable ‘bo’ set but not used [-Werror=unused-but-set-variable]
    9 |         ut8 bo[0x100];
      |             ^~
cc1: all warnings being treated as errors

Also, these are imported from binutils and will be eventually migrated to Capstone:

  • librz/asm/arch/arc/gnu/*
  • librz/asm/arch/lanai/gnu/*
  • librz/asm/arch/tricore/gnu/* by you

Probably better not to change them, if it doesn't affect CI: #2704

If it does affect CI, then it's fine to change them too, just keep in mind that eventually we hope to remove these files completely.

@XVilka XVilka merged commit 94f2fae into dev Jun 2, 2023
@XVilka XVilka deleted the fix-warn branch June 2, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants