Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emulateme binary for x86 #136

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Add emulateme binary for x86 #136

merged 3 commits into from
Jan 8, 2024

Conversation

DMaroo
Copy link
Member

@DMaroo DMaroo commented Jan 8, 2024

Also rename rzil-ppc to rzil/ppc and move emulateme.c (outside ppc) in the rzil directory.

Needed for rizinorg/rizin#4084.

@DMaroo
Copy link
Member Author

DMaroo commented Jan 8, 2024

Should I remove the renaming changes, since the check is complaining? I plan to add one more source file like emulateme.c but for floating-point operations. It makes sense for these sources to not be in a directory named rzil-ppc since they are not PPC specific.

@DMaroo DMaroo requested a review from Rot127 January 8, 2024 08:40
@wargio
Copy link
Member

wargio commented Jan 8, 2024

is complaining that you removed files, which is understandable because you moved them. ignore this

@wargio wargio requested a review from XVilka January 8, 2024 08:44
@wargio wargio merged commit 5d56d09 into master Jan 8, 2024
1 check failed
@wargio wargio deleted the x86-rzil-emulateme branch January 8, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants