Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to the rizinrc config file #103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nullun
Copy link

@nullun nullun commented Sep 26, 2023

I started out PR'ing this to dev, but it seems like there's a few outstanding commits and the last two PR's have gone straight to master, so this too is set to master, but let me know if you want me to rebase on dev.

Updated a few references of ~/.rizinrc to be ~/.config/rizin/rizinrc. Both do appear to work, but thought it would be nice to be consistent. One of the instances was an old output of the command e? which I've also included an update for.

@ret2libc
Copy link
Member

Shall we prefer ~/.rizinrc in the doc? That's where I usually place my configuration at least.

@nullun
Copy link
Author

nullun commented Sep 26, 2023

Yeah, I can switch it to that. Any technical reason other than personal preference? I noticed .config/rizin/rizinrc will trump .rizinrc if they're both set with different values.

@wargio
Copy link
Member

wargio commented Sep 27, 2023

Shall we prefer ~/.rizinrc in the doc? That's where I usually place my configuration at least.

that is also mine. but i guess we could also mention other locations.

@XVilka
Copy link
Member

XVilka commented Sep 27, 2023

I personally prefer in .config since it's the XDG standard and prevents clogging your HOME.

@nullun
Copy link
Author

nullun commented Sep 27, 2023

rizin -H states RZ_RCONFIGHOME=/home/nullun/.config/rizin as being the default configuration location for me and I haven't changed anything, but the files page in the book does suggest ~/.rizinrc as being a valid alternative which also works.

I'm in favour of using XDG standards to keep my home directory clean, but maybe we could add links to the above files page in all the places .config/rizin/rizinrc is shown?

@wargio
Copy link
Member

wargio commented Oct 2, 2023

if that is the output of the home location, than yes. that would be what should have been on the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants