fix: extraction with optional query (#24)

* add failing test * add fix
rize · Oct 12, 2022 · 5ed4ba8 · 5ed4ba8
1 parent cbded3b
commit 5ed4ba8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Rize/UriTemplate/Node/Expression.php b/src/Rize/UriTemplate/Node/Expression.php
@@ -104,7 +104,7 @@ public function match(Parser $parser, $uri, $params = array(), $strict = false)
         $op = $this->operator;
 
         // check expression operator first
-        if ($op->id && $uri[0] !== $op->id) {
+        if ($op->id && isset($uri[0]) && $uri[0] !== $op->id) {
           return array($uri, $params);
         }
 

diff --git a/test/Rize/UriTemplateTest.php b/test/Rize/UriTemplateTest.php
@@ -425,6 +425,14 @@ public function dataExtraction()
                     'number' => 0,
                 ),
             ),
+            array(
+                '/some/{path}{?ref}',
+                '/some/foo',
+                array(
+                    'path' => 'foo',
+                    'ref' => null,
+                ),
+            ),
         );
     }