fix: day 1 patch, add dashboards #3927

MasterPtato · 2026-01-16T00:14:50Z

No description provided.

railway-app · 2026-01-16T00:14:58Z

🚅 Deployed to the rivet-pr-3927 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
website	✅ Success (View Logs)	Web	Jan 16, 2026 at 11:56 pm
frontend-cloud	😴 Sleeping (View Logs)	Web	Jan 16, 2026 at 1:25 pm
frontend-inspector	😴 Sleeping (View Logs)	Web	Jan 16, 2026 at 12:16 pm

MasterPtato · 2026-01-16T00:15:15Z

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

claude · 2026-01-16T00:16:30Z

PR Review - Day 1 Patch & Dashboards

This PR adds Grafana dashboards for monitoring and includes several bug fixes. Overall the changes look good with minor improvements needed.

✅ Positive Aspects

Good Grafana Dashboard Coverage: Adding comprehensive monitoring dashboards for Epoxy and Pegboard is excellent for observability.
Metric Label Consistency: Fixed inconsistent label casing in guard routing metrics (GATEWAY/API → gateway/api) - this is important for proper metric aggregation.
Import Organization: Fixed the import placement in kv_get.rs by moving Json to the top-level imports.

🐛 Code Quality Issues

1. Unused Parameter in `publish_metrics` (engine/packages/gasoline/src/db/kv/mod.rs:623)

The parameter was changed from _worker_id to worker_id, but I don't see it being used in the visible diff. If this parameter isn't actually used in the function body, it should remain prefixed with _ to indicate intentionally unused parameters.

Action needed: Verify if worker_id is actually used now, or if this change should be reverted.

2. Metric Rename Without Migration Path (engine/packages/gasoline/src/db/kv/mod.rs:226, 623)

Changed SignalPending to SignalPending2 without explanation. This appears to be a breaking change for existing dashboards/alerts that reference the old metric name.

Concerns:

Breaking change without documentation
The 2 suffix suggests a temporary workaround rather than a proper fix
No migration path for existing monitoring

Recommendation:

Either document why the metric name changed in commit message/PR description
Or consider a more descriptive name than SignalPending2
Add a deprecation notice if the old metric is being replaced

3. Missing Documentation

The PR has an empty body. For a "day 1 patch", it would be helpful to document:

What issues were encountered on day 1 that this fixes
Why the metric names changed
Any dashboard configuration notes

📊 Metrics Changes

New Metric Added: gasoline_worker_last_metrics_publish

✅ Properly follows naming conventions
✅ Has descriptive help text
✅ Uses appropriate metric type (IntGaugeVec)
Question: How does this differ from WORKER_LAST_PING? Consider documenting the distinction.

🎯 Test Coverage

Observation: No test changes included. While dashboard additions don't require tests, the code changes to metrics and parameter usage should ideally have:

Unit tests verifying metric labels are consistent
Tests for the KV operations using the renamed metrics

Recommendation: Consider adding integration tests that validate metric collection.

🔒 Security Review

✅ No security concerns identified:

Metrics changes are internal monitoring only
Import reorganization has no security impact
Label changes don't expose new data

⚡ Performance Considerations

✅ No performance regressions expected:

Import changes are compile-time only
Metric label changes have no runtime impact
Dashboard additions don't affect backend performance

📝 Style & Conventions

Based on CLAUDE.md review:

✅ Follows conventions:

Hard tabs used in JSON files
Metric naming follows gasoline_* pattern
Lowercase metric labels

🎬 Action Items

High Priority:

Clarify the SignalPending → SignalPending2 rename rationale
Verify worker_id parameter is actually used now

Medium Priority:
3. Add PR description explaining the day 1 issues being fixed
4. Consider adding tests for metric collection

Low Priority:
5. Document the difference between WORKER_LAST_PING and WORKER_LAST_METRICS_PUBLISH

Overall Assessment: The changes are functional and improve observability, but would benefit from better documentation and clarification on the metric rename. The import fix and label consistency improvements are solid contributions.

Please address the high-priority items before merging.

pkg-pr-new · 2026-01-16T00:16:56Z

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3927

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3927

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3927

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3927

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3927

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3927

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3927

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3927

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3927

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3927

commit: 192c800

graphite-app · 2026-01-16T02:34:26Z

engine/docker/template/grafana-dashboards/epoxy.json

+					"expr": "sum by (rivet_datacenter) (rate(rivet_epoxy_proposals_total{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\"}[$__rate_interval]))",
+					"instant": false,
+					"legendFormat": "{{workflow_name}}",


Query groups by rivet_datacenter but legendFormat references {{workflow_name}} which doesn't exist in the query result. This will cause the legend to display incorrectly or be empty.

Fix:

"legendFormat": "{{rivet_datacenter}}"

Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-01-16T02:34:27Z

engine/docker/template/grafana-dashboards/epoxy.json

+					"expr": "sum by (rivet_datacenter) (rate(rivet_epoxy_pre_accept_total{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\"}[$__rate_interval]))",
+					"instant": false,
+					"legendFormat": "{{workflow_name}}",


Query groups by rivet_datacenter but legendFormat uses {{workflow_name}}. The label in the legend template must match the grouping field.

Fix:

"legendFormat": "{{rivet_datacenter}}"

Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-01-16T02:34:29Z

engine/docker/template/grafana-dashboards/epoxy.json

+					"expr": "sum by (rivet_datacenter) (rate(rivet_epoxy_accept_total{rivet_project=~\"$project\",rivet_datacenter=~\"$datacenter\"}[$__rate_interval]))",
+					"instant": false,
+					"legendFormat": "{{workflow_name}}",


Mismatch between grouping (rivet_datacenter) and legendFormat ({{workflow_name}}). This pattern repeats throughout the dashboard and will result in incorrect or missing legend labels.

Fix:

"legendFormat": "{{rivet_datacenter}}"

Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-01-16T23:57:03Z

Merge activity

Jan 16, 11:57 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Jan 16, 11:57 PM UTC: CI is running for this pull request on a draft pull request (#3950) due to your merge queue CI optimization settings.
Jan 16, 11:58 PM UTC: Merged by the Graphite merge queue via draft PR: #3950.

MasterPtato requested a review from NathanFlurry January 16, 2026 00:14

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-3927 January 16, 2026 00:15 Destroyed

MasterPtato force-pushed the 01-15-fix_day_1_patch_add_dashboards branch from f7e6088 to ee27a16 Compare January 16, 2026 02:31

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-3927 January 16, 2026 02:31 Destroyed

MasterPtato mentioned this pull request Jan 16, 2026

feat: add actor and kv metrics #3928

Closed

graphite-app bot reviewed Jan 16, 2026

View reviewed changes

fix: day 1 patch, add dashboards

192c800

MasterPtato force-pushed the 01-15-fix_day_1_patch_add_dashboards branch from ee27a16 to 192c800 Compare January 16, 2026 23:55

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-3927 January 16, 2026 23:55 Destroyed

graphite-app bot pushed a commit that referenced this pull request Jan 16, 2026

fix: day 1 patch, add dashboards (#3927)

0d5dfd1

This was referenced Jan 16, 2026

fix(gas, pb, api): make .removed events noop if dont match, add check for dead wfs to actor/runner errors, make api error types unknown #3948

Closed

fix(udb): dont configure ssl forpostgresif ssl config not set #3949

Closed

graphite-app bot closed this Jan 16, 2026

graphite-app bot deleted the 01-15-fix_day_1_patch_add_dashboards branch January 16, 2026 23:58

MasterPtato restored the 01-15-fix_day_1_patch_add_dashboards branch January 17, 2026 00:14

MasterPtato deleted the 01-15-fix_day_1_patch_add_dashboards branch January 17, 2026 00:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: day 1 patch, add dashboards #3927

fix: day 1 patch, add dashboards #3927

Uh oh!

MasterPtato commented Jan 16, 2026

Uh oh!

railway-app bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

MasterPtato commented Jan 16, 2026 •

edited

Loading

Uh oh!

claude bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

graphite-app bot Jan 16, 2026

Uh oh!

graphite-app bot Jan 16, 2026

Uh oh!

graphite-app bot Jan 16, 2026

Uh oh!

graphite-app bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: day 1 patch, add dashboards #3927

fix: day 1 patch, add dashboards #3927

Uh oh!

Conversation

MasterPtato commented Jan 16, 2026

Uh oh!

railway-app bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

claude bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review - Day 1 Patch & Dashboards

✅ Positive Aspects

🐛 Code Quality Issues

1. Unused Parameter in publish_metrics (engine/packages/gasoline/src/db/kv/mod.rs:623)

2. Metric Rename Without Migration Path (engine/packages/gasoline/src/db/kv/mod.rs:226, 623)

3. Missing Documentation

📊 Metrics Changes

🎯 Test Coverage

🔒 Security Review

⚡ Performance Considerations

📝 Style & Conventions

🎬 Action Items

Uh oh!

pkg-pr-new bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

railway-app bot commented Jan 16, 2026 •

edited

Loading

MasterPtato commented Jan 16, 2026 •

edited

Loading

claude bot commented Jan 16, 2026 •

edited

Loading

1. Unused Parameter in `publish_metrics` (engine/packages/gasoline/src/db/kv/mod.rs:623)

pkg-pr-new bot commented Jan 16, 2026 •

edited

Loading

graphite-app bot commented Jan 16, 2026 •

edited

Loading