Add make bench target, run in CI, fix failure#1166
Merged
Conversation
Add a workspace-wide `bench` target that runs `go test -bench=.` for all submodules with configurable `ITERATIONS` (default `100`). It uses `-run=a^` so regular tests are skipped during benchmark runs.
brandur
approved these changes
Mar 14, 2026
.github/workflows/ci.yaml
Outdated
| - 5432:5432 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
Probably doesn't matter much, but it's up to v6 these days.
Contributor
Author
There was a problem hiding this comment.
Ahhh thank you, fixing! 🙏
Contributor
Author
There was a problem hiding this comment.
Actually we had a few other outdated major versions in here, I fixed them all 🚀
Add a dedicated benchmark job with the same matrix as Riverpro's benchmark CI (Go 1.25/1.26 on Postgres 17). It runs `make bench ITERATIONS=1` to keep benchmark coverage in CI while staying fast.
`BenchmarkDriverRiverPgxV5_Executor` used a pooled executor without setting `Schema` on `JobGetAvailable`, so it could hit default schema and fail with missing `river_job`. Pass `Schema: bundle.schema` in both `JobGetAvailable` benchmark calls so the queries always target the migrated test schema.
bgentry
force-pushed
the
bg/bench-skip-tests
branch
from
bfdc89d to
0b88a42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing three separate issues here:
make benchtask in this project'sMakefile, so I added one.ITERATIONS=1to ensure it works but isn't slow.