Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize space in users list #1612

Closed

Conversation

fjorba
Copy link
Contributor

@fjorba fjorba commented Jul 10, 2024

Muscat inherits default ActiveAdmin actions (View, Edit, Delete) at the right of its lists. This patch removes those columns and places its links in other places, as proposed in #1405:

  • Delete column is removed, as probably it is safer to delete from the full record rather than from the list.
  • View column is linked to the Name column, as it is the "main" one, the one that clearly identifiers the record.
  • Edit column is linked to the Id colum, but only if the current user has permission to edit it; otherwise, it just shows its value. Of course, records can also be edited from the full record.

As a small improvement, date of creation column has been made sortable.

Muscat inherits default ActiveAdmin actions (View, Edit, Delete) at the
right of its lists.  This patch removes those columns and places its links
in other places, as proposed in rism-digital#1405:

* Delete column is removed, as probably it is safer to delete from the full
  record rather than from the list.
* View colum in linked to the Name column, as it is the "main" one, the one
  that clearly identifiers the record.
* Edit column is linked to the Id colum, but only if the current user has
  permission to edit it; otherwise, it just shows its value.  Of course,
  records can also be edited from the full record.

As a small improvement, date of creation column has been made sortable.
@fjorba
Copy link
Contributor Author

fjorba commented Jul 10, 2024

I'm aware that nobody has reacted to my proposal at #1405. However, here at UAB we have reorganized all Muscat tables using this principle and we feel that there is more space to work with. Moreover, in very wide screens or tables, the View or Edit table are far away from the record you intuitively would like to point to, as it is customary in web applications.

If this patch is accepted, I will send all the others. The last one will be the people list, because we have a bolder proposal using display_name (#1609) and removing life dates as specific columns. But even without that, the View, Edit and Delete links can be supressed in all lists and get more space.

@fjorba
Copy link
Contributor Author

fjorba commented Jul 23, 2024

As this proposal has no consensus (see #1405), I'm dropping it and keep as local patch.

@fjorba fjorba closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant